From deb7cf9a5ecf51c592ad0207027225a1a1c1322a Mon Sep 17 00:00:00 2001 From: Awuqing <3184394176@qq.com> Date: Tue, 31 Mar 2026 13:20:11 +0800 Subject: [PATCH] fix(test): use test TempDir for backup execution tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test passed an empty tempDir which defaulted to /tmp/backupx — a directory that does not exist in CI runners. Use t.TempDir() based path instead so the test is self-contained. --- server/internal/service/backup_execution_service_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/internal/service/backup_execution_service_test.go b/server/internal/service/backup_execution_service_test.go index db89e15..057539f 100644 --- a/server/internal/service/backup_execution_service_test.go +++ b/server/internal/service/backup_execution_service_test.go @@ -55,7 +55,11 @@ func newExecutionTestServices(t *testing.T) (*BackupExecutionService, *BackupRec runnerRegistry := backup.NewRegistry(backup.NewFileRunner(), backup.NewMySQLRunner(nil), backup.NewSQLiteRunner(), backup.NewPostgreSQLRunner(nil)) storageRegistry := storage.NewRegistry(localdisk.NewFactory()) retentionService := backupretention.NewService(records) - executionService := NewBackupExecutionService(tasks, records, targets, storageRegistry, runnerRegistry, logHub, retentionService, cipher, nil, "", 2) + tempDir := filepath.Join(baseDir, "tmp") + if err := os.MkdirAll(tempDir, 0o755); err != nil { + t.Fatalf("MkdirAll tempDir returned error: %v", err) + } + executionService := NewBackupExecutionService(tasks, records, targets, storageRegistry, runnerRegistry, logHub, retentionService, cipher, nil, tempDir, 2) recordService := NewBackupRecordService(records, executionService, logHub) return executionService, recordService, tasks, targets, records, sourceDir, storageDir }