mirror of
https://github.com/Awuqing/BackupX.git
synced 2026-05-27 19:19:35 +08:00
* fix(server): 后端直接托管 Web 控制台,修复无 nginx 时 404 (#62) 问题 #62:在未安装 nginx 的服务器上,访问 :8340/ 返回 "route not found"(404),Web 控制台完全无法打开;同时 systemd 服务以 backupx 用户启动时因无权读取 root:root 0640 的配置文件 而反复退出(exit 1)。 修复: - 后端新增 SPA 静态托管:自动探测前端目录(./web、./web/dist、 /opt/backupx/web 等,或 server.web_root 显式指定),命中后直接 提供静态文件与 index.html 回退,无需额外 nginx 反向代理即可访问 控制台。/api、/health、/metrics、/install 等保留前缀仍返回结构化 JSON 404,不会被 SPA 回退污染(沿用 issue #46 的约定)。 - 含 ".." 的请求路径由文件服务层直接拒绝,叠加 filepath.Rel 容器 校验,杜绝目录穿越。 - install.sh 以 backupx:backupx 安装配置文件并显式 chown,修复历史 版本 root:root 0640 导致服务无法读取配置而启动失败的问题;安装 完成提示同步说明可直接通过 :8340 访问,并给出 journalctl 排查命令。 - 新增 spa_test.go 覆盖目录探测、保留前缀判定、SPA 回退与穿越防护。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(security): 修复邮件头注入,加固 webhook 与整数转换 CodeQL 静态扫描在 main 上的真实告警修复: - 邮件通知(email.go):From/To/Subject 头部此前直接拼接用户可控 内容(备份任务名会进入 Subject),存在 SMTP 头注入风险(可注入 Bcc 等额外头部或伪造正文)。新增 buildRawMessage/sanitizeHeaderValue 剔除头部值中的 CR/LF;正文保持原样。新增 email_test.go 覆盖。 - webhook 通知(webhook.go):Validate 增加 URL 解析与 http/https 协议校验,杜绝 file://、gopher:// 等可用于 SSRF 的协议。 - 整数转换(auth_service.go、storage_target_handler.go、 backup_record_handler.go):将 ParseUint 的 bitSize 由 64 改为 0 (即 uint 宽度),消除 uint64→uint 的潜在截断(32 位平台上为越界 拒绝而非静默截断),并清除 go/incorrect-integer-conversion 告警。 注:archive.go/file_runner.go 的 zipslip 告警为误报(已有 HasPrefix 容器校验且不解压符号链接);node FS 浏览与 webhook 目标主机由设计上 的鉴权用户控制,不在本次行为变更范围内。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
225 lines
6.2 KiB
Go
225 lines
6.2 KiB
Go
package http
|
||
|
||
import (
|
||
"encoding/json"
|
||
"fmt"
|
||
"io"
|
||
"strconv"
|
||
"strings"
|
||
"time"
|
||
|
||
"backupx/server/internal/apperror"
|
||
"backupx/server/internal/backup"
|
||
"backupx/server/internal/service"
|
||
"backupx/server/pkg/response"
|
||
"github.com/gin-gonic/gin"
|
||
)
|
||
|
||
type BackupRecordHandler struct {
|
||
service *service.BackupRecordService
|
||
restoreService *service.RestoreService
|
||
auditService *service.AuditService
|
||
}
|
||
|
||
func NewBackupRecordHandler(recordService *service.BackupRecordService, restoreService *service.RestoreService, auditService *service.AuditService) *BackupRecordHandler {
|
||
return &BackupRecordHandler{service: recordService, restoreService: restoreService, auditService: auditService}
|
||
}
|
||
|
||
func (h *BackupRecordHandler) List(c *gin.Context) {
|
||
filter, err := buildRecordFilter(c)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
items, err := h.service.List(c.Request.Context(), filter)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
response.Success(c, items)
|
||
}
|
||
|
||
func (h *BackupRecordHandler) Get(c *gin.Context) {
|
||
id, ok := parseUintParam(c, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
item, err := h.service.Get(c.Request.Context(), id)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
response.Success(c, item)
|
||
}
|
||
|
||
func (h *BackupRecordHandler) StreamLogs(c *gin.Context) {
|
||
id, ok := parseUintParam(c, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
detail, err := h.service.Get(c.Request.Context(), id)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
events := detail.LogEvents
|
||
completed := detail.Status != "running"
|
||
channel, cancel, err := h.service.SubscribeLogs(c.Request.Context(), id, 64)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
defer cancel()
|
||
c.Writer.Header().Set("Content-Type", "text/event-stream")
|
||
c.Writer.Header().Set("Cache-Control", "no-cache")
|
||
c.Writer.Header().Set("Connection", "keep-alive")
|
||
flusher, ok := c.Writer.(interface{ Flush() })
|
||
if !ok {
|
||
response.Error(c, apperror.Internal("BACKUP_RECORD_STREAM_UNSUPPORTED", "当前连接不支持日志流", nil))
|
||
return
|
||
}
|
||
for _, event := range events {
|
||
if err := writeSSEEvent(c.Writer, event); err != nil {
|
||
return
|
||
}
|
||
flusher.Flush()
|
||
}
|
||
if completed {
|
||
return
|
||
}
|
||
for {
|
||
select {
|
||
case <-c.Request.Context().Done():
|
||
return
|
||
case event, ok := <-channel:
|
||
if !ok {
|
||
return
|
||
}
|
||
if err := writeSSEEvent(c.Writer, event); err != nil {
|
||
return
|
||
}
|
||
flusher.Flush()
|
||
if event.Completed {
|
||
return
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
func (h *BackupRecordHandler) Download(c *gin.Context) {
|
||
id, ok := parseUintParam(c, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
result, err := h.service.Download(c.Request.Context(), id)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
defer result.Reader.Close()
|
||
c.Header("Content-Disposition", fmt.Sprintf("attachment; filename=%q", result.FileName))
|
||
c.Header("Content-Type", "application/octet-stream")
|
||
_, _ = io.Copy(c.Writer, result.Reader)
|
||
}
|
||
|
||
// Restore 启动一次异步恢复并返回 restoreRecordId;实际执行路由由 RestoreService
|
||
// 根据 task.NodeID 决定(本地 Master or 远程 Agent)。
|
||
func (h *BackupRecordHandler) Restore(c *gin.Context) {
|
||
id, ok := parseUintParam(c, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
if h.restoreService == nil {
|
||
response.Error(c, apperror.Internal("RESTORE_SERVICE_DISABLED", "恢复服务未启用", nil))
|
||
return
|
||
}
|
||
triggeredBy := ""
|
||
if subject, exists := c.Get(contextUserSubjectKey); exists {
|
||
triggeredBy = strings.TrimSpace(fmt.Sprintf("%v", subject))
|
||
}
|
||
detail, err := h.restoreService.Start(c.Request.Context(), id, triggeredBy)
|
||
if err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
recordAudit(c, h.auditService, "backup_record", "restore", "backup_record", fmt.Sprintf("%d", id), "",
|
||
fmt.Sprintf("启动恢复 (备份记录 ID: %d, 恢复记录 ID: %d)", id, detail.ID))
|
||
response.Success(c, detail)
|
||
}
|
||
|
||
func (h *BackupRecordHandler) Delete(c *gin.Context) {
|
||
id, ok := parseUintParam(c, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
if err := h.service.Delete(c.Request.Context(), id); err != nil {
|
||
response.Error(c, err)
|
||
return
|
||
}
|
||
recordAudit(c, h.auditService, "backup_record", "delete", "backup_record", fmt.Sprintf("%d", id), "",
|
||
fmt.Sprintf("删除备份记录 (ID: %d)", id))
|
||
response.Success(c, gin.H{"deleted": true})
|
||
}
|
||
|
||
func (h *BackupRecordHandler) BatchDelete(c *gin.Context) {
|
||
var input struct {
|
||
IDs []uint `json:"ids" binding:"required,min=1"`
|
||
}
|
||
if err := c.ShouldBindJSON(&input); err != nil {
|
||
response.Error(c, apperror.BadRequest("BACKUP_RECORD_BATCH_INVALID", "批量删除参数不合法", err))
|
||
return
|
||
}
|
||
deleted := 0
|
||
for _, id := range input.IDs {
|
||
if err := h.service.Delete(c.Request.Context(), id); err == nil {
|
||
deleted++
|
||
}
|
||
}
|
||
recordAudit(c, h.auditService, "backup_record", "batch_delete", "backup_record", "", "", fmt.Sprintf("批量删除 %d 条备份记录", deleted))
|
||
response.Success(c, gin.H{"deleted": deleted})
|
||
}
|
||
|
||
func buildRecordFilter(c *gin.Context) (service.BackupRecordListInput, error) {
|
||
var filter service.BackupRecordListInput
|
||
if taskIDValue := strings.TrimSpace(c.Query("taskId")); taskIDValue != "" {
|
||
parsed, ok := parseUintString(taskIDValue)
|
||
if !ok {
|
||
return filter, apperror.BadRequest("BACKUP_RECORD_FILTER_INVALID", "taskId 不合法", nil)
|
||
}
|
||
filter.TaskID = &parsed
|
||
}
|
||
filter.Status = strings.TrimSpace(c.Query("status"))
|
||
if dateFrom := strings.TrimSpace(c.Query("dateFrom")); dateFrom != "" {
|
||
parsed, err := time.Parse(time.RFC3339, dateFrom)
|
||
if err != nil {
|
||
return filter, apperror.BadRequest("BACKUP_RECORD_FILTER_INVALID", "dateFrom 必须为 RFC3339 时间格式", err)
|
||
}
|
||
filter.DateFrom = &parsed
|
||
}
|
||
if dateTo := strings.TrimSpace(c.Query("dateTo")); dateTo != "" {
|
||
parsed, err := time.Parse(time.RFC3339, dateTo)
|
||
if err != nil {
|
||
return filter, apperror.BadRequest("BACKUP_RECORD_FILTER_INVALID", "dateTo 必须为 RFC3339 时间格式", err)
|
||
}
|
||
filter.DateTo = &parsed
|
||
}
|
||
return filter, nil
|
||
}
|
||
|
||
func writeSSEEvent(writer io.Writer, event backup.LogEvent) error {
|
||
payload, err := json.Marshal(event)
|
||
if err != nil {
|
||
return err
|
||
}
|
||
_, err = fmt.Fprintf(writer, "event: log\ndata: %s\n\n", payload)
|
||
return err
|
||
}
|
||
|
||
func parseUintString(value string) (uint, bool) {
|
||
parsed, err := strconv.ParseUint(strings.TrimSpace(value), 10, 0)
|
||
if err != nil {
|
||
return 0, false
|
||
}
|
||
return uint(parsed), true
|
||
}
|