mirror of
https://github.com/DrizzleTime/Foxel.git
synced 2026-09-09 01:27:24 +08:00
refactor: Remove unused props from GridView component and clean up related code
This commit is contained in:
@@ -121,8 +121,6 @@ const FileExplorerPage = memo(function FileExplorerPage() {
|
|||||||
onSelectRange={handleSelectRange}
|
onSelectRange={handleSelectRange}
|
||||||
onOpen={handleOpenEntry}
|
onOpen={handleOpenEntry}
|
||||||
onContextMenu={openContextMenu}
|
onContextMenu={openContextMenu}
|
||||||
onCreateDir={() => setCreatingDir(true)}
|
|
||||||
onGoUp={goUp}
|
|
||||||
/>
|
/>
|
||||||
) : (
|
) : (
|
||||||
<FileListView
|
<FileListView
|
||||||
|
|||||||
@@ -8,19 +8,13 @@ import { EmptyState } from './EmptyState';
|
|||||||
interface Props {
|
interface Props {
|
||||||
entries: VfsEntry[];
|
entries: VfsEntry[];
|
||||||
thumbs: Record<string, string>;
|
thumbs: Record<string, string>;
|
||||||
// ...existing code...
|
|
||||||
// selected was single entry before; now use selectedEntries for multi-select
|
|
||||||
selectedEntries: string[];
|
selectedEntries: string[];
|
||||||
loading: boolean;
|
loading: boolean;
|
||||||
path: string;
|
path: string;
|
||||||
// onSelect: clicked entry, additive indicates Ctrl/Cmd click to toggle
|
|
||||||
onSelect: (e: VfsEntry, additive?: boolean) => void;
|
onSelect: (e: VfsEntry, additive?: boolean) => void;
|
||||||
// onSelectRange: called when marquee/selecting multiple by box
|
|
||||||
onSelectRange: (names: string[]) => void;
|
onSelectRange: (names: string[]) => void;
|
||||||
onOpen: (e: VfsEntry) => void;
|
onOpen: (e: VfsEntry) => void;
|
||||||
onContextMenu: (e: React.MouseEvent, entry: VfsEntry) => void;
|
onContextMenu: (e: React.MouseEvent, entry: VfsEntry) => void;
|
||||||
onCreateDir: () => void;
|
|
||||||
onGoUp: () => void;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const formatSize = (size: number) => {
|
const formatSize = (size: number) => {
|
||||||
@@ -30,10 +24,8 @@ const formatSize = (size: number) => {
|
|||||||
return (size / 1024 / 1024 / 1024).toFixed(1) + ' GB';
|
return (size / 1024 / 1024 / 1024).toFixed(1) + ' GB';
|
||||||
};
|
};
|
||||||
|
|
||||||
export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, loading, path, onSelect, onSelectRange, onOpen, onContextMenu, onCreateDir, onGoUp }) => {
|
export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, loading, path, onSelect, onSelectRange, onOpen, onContextMenu }) => {
|
||||||
const { token } = theme.useToken();
|
const { token } = theme.useToken();
|
||||||
|
|
||||||
// refs for marquee selection
|
|
||||||
const containerRef = useRef<HTMLDivElement | null>(null);
|
const containerRef = useRef<HTMLDivElement | null>(null);
|
||||||
const itemRefs = useRef<Record<string, HTMLDivElement | null>>({});
|
const itemRefs = useRef<Record<string, HTMLDivElement | null>>({});
|
||||||
const startRef = useRef<{ x: number, y: number } | null>(null);
|
const startRef = useRef<{ x: number, y: number } | null>(null);
|
||||||
@@ -52,12 +44,11 @@ export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, lo
|
|||||||
const height = Math.abs(cy - s.y);
|
const height = Math.abs(cy - s.y);
|
||||||
setRect({ left, top, width, height });
|
setRect({ left, top, width, height });
|
||||||
};
|
};
|
||||||
const onUp = () => { // 不需要 MouseEvent 参数,避免未使用警告
|
const onUp = () => {
|
||||||
if (!startRef.current) return;
|
if (!startRef.current) return;
|
||||||
setSelecting(false);
|
setSelecting(false);
|
||||||
const r = rect;
|
const r = rect;
|
||||||
if (r) {
|
if (r) {
|
||||||
// compute intersecting items
|
|
||||||
const container = containerRef.current;
|
const container = containerRef.current;
|
||||||
if (container) {
|
if (container) {
|
||||||
const sel: string[] = [];
|
const sel: string[] = [];
|
||||||
@@ -89,17 +80,14 @@ export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, lo
|
|||||||
}, [selecting, rect, entries, onSelectRange]);
|
}, [selecting, rect, entries, onSelectRange]);
|
||||||
|
|
||||||
const handleMouseDown = (e: React.MouseEvent) => {
|
const handleMouseDown = (e: React.MouseEvent) => {
|
||||||
// only left button and not on an item actionable element
|
|
||||||
if (e.button !== 0) return;
|
if (e.button !== 0) return;
|
||||||
// start marquee if click on empty space inside container
|
|
||||||
const target = e.target as HTMLElement;
|
const target = e.target as HTMLElement;
|
||||||
if (target.closest('.fx-grid-item')) {
|
if (target.closest('.fx-grid-item')) {
|
||||||
return; // clicks on item handled separately
|
return;
|
||||||
}
|
}
|
||||||
startRef.current = { x: e.clientX, y: e.clientY };
|
startRef.current = { x: e.clientX, y: e.clientY };
|
||||||
setSelecting(true);
|
setSelecting(true);
|
||||||
setRect({ left: e.clientX, top: e.clientY, width: 0, height: 0 });
|
setRect({ left: e.clientX, top: e.clientY, width: 0, height: 0 });
|
||||||
// prevent text selection
|
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -113,10 +101,9 @@ export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, lo
|
|||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
key={ent.name}
|
key={ent.name}
|
||||||
ref={(el) => { itemRefs.current[ent.name] = el; }} // 确保函数不返回值,匹配 Ref 类型
|
ref={(el) => { itemRefs.current[ent.name] = el; }}
|
||||||
className={['fx-grid-item', isSelected ? 'selected' : '', ent.is_dir ? 'dir' : 'file'].join(' ')}
|
className={['fx-grid-item', isSelected ? 'selected' : '', ent.is_dir ? 'dir' : 'file'].join(' ')}
|
||||||
onClick={(ev) => {
|
onClick={(ev) => {
|
||||||
// click selection: support ctrl/cmd to toggle
|
|
||||||
const additive = ev.ctrlKey || ev.metaKey;
|
const additive = ev.ctrlKey || ev.metaKey;
|
||||||
onSelect(ent, additive);
|
onSelect(ent, additive);
|
||||||
}}
|
}}
|
||||||
@@ -149,7 +136,7 @@ export const GridView: React.FC<Props> = ({ entries, thumbs, selectedEntries, lo
|
|||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
{loading && <div style={{ width: '100%', textAlign: 'center', padding: 40 }}><Spin /></div>}
|
{loading && <div style={{ width: '100%', textAlign: 'center', padding: 40 }}><Spin /></div>}
|
||||||
{!loading && entries.length === 0 && <EmptyState isRoot={path==='/' } onCreateDir={onCreateDir} onGoUp={onGoUp} />}
|
{!loading && entries.length === 0 && <EmptyState isRoot={path === '/'} />}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
Reference in New Issue
Block a user