refactor: unify music subscription data port

This commit is contained in:
jxxghp
2026-08-24 04:20:06 +08:00
parent a13c96d30b
commit 286b5836a1
5 changed files with 38 additions and 14 deletions
+15
View File
@@ -452,6 +452,21 @@ def test_user_and_messaging_chains_use_explicit_data_port_getters():
assert violations == []
def test_music_chain_uses_explicit_subscribe_data_port_getter():
"""音乐订阅链不得把 SubscribePortProxy 伪装成 SubscribeOper。"""
path = APP_ROOT / "chain" / "_music.py"
tree = ast.parse(path.read_text(encoding="utf-8-sig"), filename=str(path))
violations = [
f"{path.relative_to(PROJECT_ROOT).as_posix()}:{node.lineno}"
for node in ast.walk(tree)
if isinstance(node, ast.ImportFrom)
and node.module == "app.application.chain.data"
and any(alias.name == "SubscribePortProxy" for alias in node.names)
]
assert violations == []
def test_plugin_components_do_not_reexport_legacy_abi_names():
"""新插件组件只提供 canonical 能力,不得复制旧 Helper、Manager 或 Oper 导出。"""
violations: list[str] = []
+4 -4
View File
@@ -134,7 +134,7 @@ def test_music_subscribe_reuses_search_download_and_finish_flow():
with patch.object(SubscribeChain, "_recognize_music_subscribe", return_value=target), \
patch("app.chain._music.SearchChain", return_value=search_chain), \
patch("app.chain._music.DownloadChain", return_value=download_chain), \
patch("app.chain._music.SubscribeOper") as subscribe_oper:
patch("app.chain._music.get_chain_subscribe_port") as subscribe_oper:
subscribe_oper.return_value.get.return_value = subscribe
chain._search_music_subscribe(subscribe)
@@ -240,7 +240,7 @@ def test_music_best_version_persists_downloaded_rule_priority():
chain.finish_subscribe_or_not = Mock()
with patch("app.chain._music.DownloadChain", return_value=download_chain), \
patch("app.chain._music.SubscribeOper", return_value=subscribe_oper):
patch("app.chain._music.get_chain_subscribe_port", return_value=subscribe_oper):
chain._download_music_subscribe(subscribe, _music_info(), [downloaded])
subscribe_oper.update.assert_called_once_with(
@@ -441,7 +441,7 @@ def test_music_rss_match_reuses_cached_context_without_second_site_search():
torrent_helper.filter_torrent.return_value = True
with patch.object(SubscribeChain, "_recognize_music_subscribe", return_value=target), \
patch("app.chain.subscribe.SubscribeOper", return_value=subscribe_oper), \
patch("app.chain._music.SubscribeOper", return_value=subscribe_oper), \
patch("app.chain._music.get_chain_subscribe_port", return_value=subscribe_oper), \
patch("app.chain._music.TorrentHelper", return_value=torrent_helper), \
patch("app.chain._music.DownloadChain", return_value=download_chain), \
patch("app.chain.subscribe.SearchChain") as search_chain, \
@@ -638,7 +638,7 @@ def test_recording_target_sync_clears_stale_album_track_count():
subscribe = _subscribe(total_tracks=11)
subscribe_oper = Mock()
with patch("app.chain._music.SubscribeOper", return_value=subscribe_oper):
with patch("app.chain._music.get_chain_subscribe_port", return_value=subscribe_oper):
SubscribeChain._sync_music_subscribe_target(subscribe, _music_info())
subscribe_oper.update.assert_called_once_with(subscribe.id, {"total_tracks": None})