refactor: unify mediaserver chain data port

This commit is contained in:
jxxghp
2026-08-24 04:30:05 +08:00
parent 836cbfbbb2
commit fb08e06277
5 changed files with 47 additions and 15 deletions
+15
View File
@@ -486,6 +486,21 @@ def test_site_chains_use_explicit_site_data_port_getter():
assert violations == []
def test_mediaserver_chain_uses_explicit_data_port_getter():
"""媒体服务器链不得把 MediaServerPortProxy 伪装成 MediaServerOper。"""
path = APP_ROOT / "chain" / "mediaserver.py"
tree = ast.parse(path.read_text(encoding="utf-8-sig"), filename=str(path))
violations = [
f"{path.relative_to(PROJECT_ROOT).as_posix()}:{node.lineno}"
for node in ast.walk(tree)
if isinstance(node, ast.ImportFrom)
and node.module == "app.application.chain.data"
and any(alias.name == "MediaServerPortProxy" for alias in node.names)
]
assert violations == []
def test_plugin_components_do_not_reexport_legacy_abi_names():
"""新插件组件只提供 canonical 能力,不得复制旧 Helper、Manager 或 Oper 导出。"""
violations: list[str] = []
+13 -5
View File
@@ -103,7 +103,7 @@ def test_sync_persists_music_without_querying_tv_episodes(database):
with database() as session:
with patch.object(
MEDIA_SERVER_CHAIN_MODULE,
"MediaServerOper",
"get_chain_media_server_port",
lambda: MediaServerOper(session),
), patch.object(
MEDIA_SERVER_CHAIN_MODULE.ServiceConfigHelper,
@@ -196,7 +196,7 @@ def test_sync_updates_rows_and_removes_stale_entries(database):
with database() as session:
with patch.object(
MEDIA_SERVER_CHAIN_MODULE,
"MediaServerOper",
"get_chain_media_server_port",
lambda: MediaServerOper(session),
), patch.object(
MEDIA_SERVER_CHAIN_MODULE.ServiceConfigHelper,
@@ -280,7 +280,7 @@ def test_sync_queries_counts_before_items_and_reports_media_progress(database):
with database() as session:
with patch.object(
MEDIA_SERVER_CHAIN_MODULE,
"MediaServerOper",
"get_chain_media_server_port",
lambda: MediaServerOper(session),
), patch.object(
MEDIA_SERVER_CHAIN_MODULE.ServiceConfigHelper,
@@ -334,7 +334,11 @@ def test_sync_targets_one_server_without_excluding_other_enabled_servers(monkeyp
excluded_server_calls.append(servers)
chain.librarys = lambda server: library_calls.append(server) or []
monkeypatch.setattr(MEDIA_SERVER_CHAIN_MODULE, "MediaServerOper", FakeMediaServerOper)
monkeypatch.setattr(
MEDIA_SERVER_CHAIN_MODULE,
"get_chain_media_server_port",
FakeMediaServerOper,
)
monkeypatch.setattr(
MEDIA_SERVER_CHAIN_MODULE.ServiceConfigHelper,
"get_mediaserver_configs",
@@ -367,7 +371,11 @@ def test_sync_stops_without_emitting_completion_after_stop_signal(monkeypatch):
global_vars.stop_system()
return 0, 0
monkeypatch.setattr(MEDIA_SERVER_CHAIN_MODULE, "MediaServerOper", FakeMediaServerOper)
monkeypatch.setattr(
MEDIA_SERVER_CHAIN_MODULE,
"get_chain_media_server_port",
FakeMediaServerOper,
)
monkeypatch.setattr(
chain,
"_prepare_sync_contexts",