mirror of
https://github.com/Syngnat/GoNavi.git
synced 2026-06-28 17:31:32 +08:00
🐛 fix(frontend): 修复 DuckDB 对象编辑与安全修改回归
- 修复 DuckDB qualified table 在查询结果页丢失 schema 导致无法识别主键的问题 - 打开对象修改前强制刷新最新定义,并避免切换对象失败时沿用旧定义 - 为 DuckDB 元数据链路补充前后端回归测试,并给 app 层真实 runtime 测试增加环境门槛
This commit is contained in:
@@ -86,6 +86,7 @@ describe('TriggerViewer object edit entry', () => {
|
||||
storeState.addTab.mockReset();
|
||||
storeState.setActiveContext.mockReset();
|
||||
storeState.connections[0].config.type = 'postgres';
|
||||
backendApp.DBQuery.mockReset();
|
||||
backendApp.DBQuery.mockResolvedValue({
|
||||
success: true,
|
||||
data: [{ trigger_definition: 'CREATE TRIGGER users_bi BEFORE INSERT ON audit.users EXECUTE FUNCTION audit.audit_users();' }],
|
||||
@@ -170,4 +171,102 @@ describe('TriggerViewer object edit entry', () => {
|
||||
expect(query).toContain(':NEW.updated_at := SYSDATE;');
|
||||
expect(query).not.toContain('请补全 CREATE TRIGGER 语句');
|
||||
});
|
||||
|
||||
it('reloads the latest trigger definition before opening object edit', async () => {
|
||||
backendApp.DBQuery
|
||||
.mockResolvedValueOnce({
|
||||
success: true,
|
||||
data: [{ trigger_definition: 'CREATE TRIGGER users_bi BEFORE INSERT ON audit.users EXECUTE FUNCTION audit.audit_users();' }],
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
success: true,
|
||||
data: [{ trigger_definition: 'CREATE TRIGGER users_bi BEFORE INSERT OR UPDATE ON audit.users EXECUTE FUNCTION audit.audit_users_v2();' }],
|
||||
});
|
||||
|
||||
let renderer: any;
|
||||
await act(async () => {
|
||||
renderer = create(<TriggerViewer tab={tab} />);
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
const button = renderer.root.findAll((node: any) => node.type === 'button' && findButtonText(node).includes('对象修改'))[0];
|
||||
|
||||
await act(async () => {
|
||||
await button.props.onClick();
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
expect(backendApp.DBQuery).toHaveBeenCalledTimes(2);
|
||||
const query = storeState.addTab.mock.calls[0][0].query;
|
||||
expect(query).toContain('CREATE TRIGGER users_bi BEFORE INSERT OR UPDATE ON audit.users');
|
||||
expect(query).toContain('audit.audit_users_v2()');
|
||||
|
||||
const editor = renderer.root.findAll((node: any) => node.props['data-editor'] === 'true')[0];
|
||||
expect(String(editor.children.join(''))).toContain('CREATE TRIGGER users_bi BEFORE INSERT OR UPDATE ON audit.users');
|
||||
});
|
||||
|
||||
it('keeps the current trigger definition visible when refresh for object edit fails', async () => {
|
||||
backendApp.DBQuery
|
||||
.mockResolvedValueOnce({
|
||||
success: true,
|
||||
data: [{ trigger_definition: 'CREATE TRIGGER users_bi BEFORE INSERT ON audit.users EXECUTE FUNCTION audit.audit_users();' }],
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
success: false,
|
||||
message: 'refresh failed',
|
||||
data: [],
|
||||
});
|
||||
|
||||
let renderer: any;
|
||||
await act(async () => {
|
||||
renderer = create(<TriggerViewer tab={tab} />);
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
const button = renderer.root.findAll((node: any) => node.type === 'button' && findButtonText(node).includes('对象修改'))[0];
|
||||
|
||||
await act(async () => {
|
||||
await button.props.onClick();
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
expect(storeState.addTab).not.toHaveBeenCalled();
|
||||
expect(String(renderer.root.findAll((node: any) => node.props['data-editor'] === 'true')[0].children.join(''))).toContain('CREATE TRIGGER users_bi BEFORE INSERT ON audit.users');
|
||||
expect(findButtonText(renderer.root)).toContain('刷新最新定义失败');
|
||||
expect(findButtonText(renderer.root)).toContain('refresh failed');
|
||||
});
|
||||
|
||||
it('does not keep the previous trigger definition when switching objects and the new load fails', async () => {
|
||||
backendApp.DBQuery
|
||||
.mockResolvedValueOnce({
|
||||
success: true,
|
||||
data: [{ trigger_definition: 'CREATE TRIGGER users_bi BEFORE INSERT ON audit.users EXECUTE FUNCTION audit.audit_users();' }],
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
success: false,
|
||||
message: 'load failed',
|
||||
data: [],
|
||||
});
|
||||
|
||||
let renderer: any;
|
||||
await act(async () => {
|
||||
renderer = create(<TriggerViewer tab={tab} />);
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
await act(async () => {
|
||||
renderer.update(<TriggerViewer tab={{
|
||||
...tab,
|
||||
id: 'trigger-conn-1-main-audit.users_bu',
|
||||
title: '触发器: audit.users_bu',
|
||||
triggerName: 'audit.users_bu',
|
||||
}} />);
|
||||
await flushPromises();
|
||||
});
|
||||
|
||||
expect(findButtonText(renderer.root)).toContain('加载失败');
|
||||
expect(findButtonText(renderer.root)).toContain('load failed');
|
||||
expect(renderer.root.findAll((node: any) => node.props['data-editor'] === 'true')).toHaveLength(0);
|
||||
expect(findButtonText(renderer.root)).not.toContain('CREATE TRIGGER users_bi BEFORE INSERT');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user