From b6189274545222c4b70cd1de8c47f3b2f49abf43 Mon Sep 17 00:00:00 2001 From: Syngnat <92659908+Syngnat@users.noreply.github.com> Date: Tue, 7 Jul 2026 16:48:27 +0800 Subject: [PATCH] test(oceanbase): cover Oracle query timeout default --- internal/app/db_context_oceanbase_oracle_test.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/internal/app/db_context_oceanbase_oracle_test.go b/internal/app/db_context_oceanbase_oracle_test.go index bd831bac..3f3cebc8 100644 --- a/internal/app/db_context_oceanbase_oracle_test.go +++ b/internal/app/db_context_oceanbase_oracle_test.go @@ -20,6 +20,9 @@ func TestNormalizeRunConfig_OceanBaseOracleAddsCurrentSchemaInit(t *testing.T) { if runConfig.Database != "OBORCL" { t.Fatalf("expected OceanBase Oracle service name to stay OBORCL, got %q", runConfig.Database) } + if runConfig.Timeout != defaultOceanBaseOracleQueryTimeoutSeconds { + t.Fatalf("expected OceanBase Oracle default query timeout %d, got %d", defaultOceanBaseOracleQueryTimeoutSeconds, runConfig.Timeout) + } values, err := url.ParseQuery(runConfig.ConnectionParams) if err != nil { t.Fatalf("unexpected connection params parse error: %v", err) @@ -30,17 +33,21 @@ func TestNormalizeRunConfig_OceanBaseOracleAddsCurrentSchemaInit(t *testing.T) { } } -func TestNormalizeRunConfig_OceanBaseOraclePreservesExistingInit(t *testing.T) { +func TestNormalizeRunConfig_OceanBaseOraclePreservesExplicitTimeoutAndExistingInit(t *testing.T) { t.Parallel() config := connection.ConnectionConfig{ Type: "oceanbase", Database: "OBORCL", OceanBaseProtocol: "oracle", + Timeout: 45, ConnectionParams: "init=ALTER+SESSION+SET+NLS_DATE_FORMAT%3D%27YYYY-MM-DD%27&timeout=10s", } runConfig := normalizeRunConfig(config, "sbdev") + if runConfig.Timeout != 45 { + t.Fatalf("expected explicit timeout to be preserved, got %d", runConfig.Timeout) + } values, err := url.ParseQuery(runConfig.ConnectionParams) if err != nil { t.Fatalf("unexpected connection params parse error: %v", err)