diff --git a/frontend/src/utils/queryAutoLimit.test.ts b/frontend/src/utils/queryAutoLimit.test.ts index 32964a75..bb4ea131 100644 --- a/frontend/src/utils/queryAutoLimit.test.ts +++ b/frontend/src/utils/queryAutoLimit.test.ts @@ -32,9 +32,9 @@ describe('applyQueryAutoLimit', () => { ['dameng'], ['dm'], ['dm8'], - ])('adds FETCH FIRST limit for %s connections', (dbType) => { + ])('adds ROWNUM limit for %s connections', (dbType) => { expect(applyQueryAutoLimit('SELECT * FROM MYCIMLED.EDC_LOG', dbType, 500).sql) - .toBe('SELECT * FROM MYCIMLED.EDC_LOG FETCH FIRST 500 ROWS ONLY'); + .toBe('SELECT * FROM (SELECT * FROM MYCIMLED.EDC_LOG) WHERE ROWNUM <= 500'); }); it.each([ @@ -53,8 +53,8 @@ describe('applyQueryAutoLimit', () => { }); it.each([ - ['oracle', 'SELECT * FROM users FETCH FIRST 500 ROWS ONLY'], - ['dm8', 'SELECT * FROM users FETCH FIRST 500 ROWS ONLY'], + ['oracle', 'SELECT * FROM (SELECT * FROM users) WHERE ROWNUM <= 500'], + ['dm8', 'SELECT * FROM (SELECT * FROM users) WHERE ROWNUM <= 500'], ['mssql', 'SELECT TOP 500 * FROM users'], ['postgresql', 'SELECT * FROM users LIMIT 500'], ['doris', 'SELECT * FROM users LIMIT 500'], @@ -66,7 +66,12 @@ describe('applyQueryAutoLimit', () => { it('keeps trailing semicolon and comments after injected Oracle limit', () => { expect(applyQueryAutoLimit('SELECT * FROM MYCIMLED.EDC_LOG; -- preview', 'oracle', 500).sql) - .toBe('SELECT * FROM MYCIMLED.EDC_LOG FETCH FIRST 500 ROWS ONLY; -- preview'); + .toBe('SELECT * FROM (SELECT * FROM MYCIMLED.EDC_LOG) WHERE ROWNUM <= 500; -- preview'); + }); + + it('uses Oracle 11g compatible ROWNUM limit for simple table queries', () => { + expect(applyQueryAutoLimit('select 1 from xxx', 'oracle', 500).sql) + .toBe('SELECT * FROM (select 1 from xxx) WHERE ROWNUM <= 500'); }); it('does not add another generic limit when SQL already limits rows', () => { @@ -88,6 +93,11 @@ describe('applyQueryAutoLimit', () => { .toBe(false); }); + it('does not wrap Oracle FOR UPDATE queries', () => { + expect(applyQueryAutoLimit('SELECT * FROM users FOR UPDATE', 'oracle', 500).applied) + .toBe(false); + }); + it('does not add another SQL Server limit when SQL already uses TOP', () => { expect(applyQueryAutoLimit('SELECT TOP 10 * FROM users', 'sqlserver', 500).applied) .toBe(false); diff --git a/frontend/src/utils/queryAutoLimit.ts b/frontend/src/utils/queryAutoLimit.ts index 8b8560ce..f2e0aa72 100644 --- a/frontend/src/utils/queryAutoLimit.ts +++ b/frontend/src/utils/queryAutoLimit.ts @@ -320,7 +320,9 @@ export const applyQueryAutoLimit = ( if (rownumPos >= 0) return { sql, applied: false, maxRows }; const offsetPos = findTopLevelKeyword(main, 'offset'); if (offsetPos >= 0 && (fromPos < 0 || offsetPos > fromPos)) return { sql, applied: false, maxRows }; - return { sql: `${main.trimEnd()} FETCH FIRST ${maxRows} ROWS ONLY${tail}`, applied: true, maxRows }; + const forPos = findTopLevelKeyword(main, 'for'); + if (forPos >= 0 && (fromPos < 0 || forPos > fromPos)) return { sql, applied: false, maxRows }; + return { sql: `SELECT * FROM (${main.trimEnd()}) WHERE ROWNUM <= ${maxRows}${tail}`, applied: true, maxRows }; } const offsetPos = findTopLevelKeyword(main, 'offset');