From fca3f0cffbcb4f634c942c79e4edfa4043403f9b Mon Sep 17 00:00:00 2001 From: Syngnat <92659908+Syngnat@users.noreply.github.com> Date: Wed, 8 Jul 2026 12:05:14 +0800 Subject: [PATCH 1/2] fix(oceanbase): make Oracle sequence metadata queries tolerant --- internal/app/methods_db_objects.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/internal/app/methods_db_objects.go b/internal/app/methods_db_objects.go index 7c908162..32e31ac6 100644 --- a/internal/app/methods_db_objects.go +++ b/internal/app/methods_db_objects.go @@ -417,9 +417,16 @@ func buildObjectSequenceMetadataQueries(dbType string, dbName string) []objectMe switch dbType { case "oracle", "dameng": if strings.TrimSpace(dbName) == "" { - return []objectMetadataQuerySpec{{sql: "SELECT SEQUENCE_NAME AS sequence_name FROM USER_SEQUENCES ORDER BY SEQUENCE_NAME"}} + return []objectMetadataQuerySpec{ + {sql: "SELECT * FROM USER_SEQUENCES ORDER BY SEQUENCE_NAME"}, + {sql: "SELECT OBJECT_NAME AS sequence_name FROM USER_OBJECTS WHERE OBJECT_TYPE = 'SEQUENCE' ORDER BY OBJECT_NAME"}, + } + } + owner := strings.ToUpper(safeDbName) + return []objectMetadataQuerySpec{ + {sql: fmt.Sprintf("SELECT * FROM ALL_SEQUENCES WHERE SEQUENCE_OWNER = '%s' ORDER BY SEQUENCE_NAME", owner)}, + {sql: fmt.Sprintf("SELECT OWNER AS schema_name, OBJECT_NAME AS sequence_name FROM ALL_OBJECTS WHERE OWNER = '%s' AND OBJECT_TYPE = 'SEQUENCE' ORDER BY OBJECT_NAME", owner)}, } - return []objectMetadataQuerySpec{{sql: fmt.Sprintf("SELECT SEQUENCE_OWNER AS schema_name, SEQUENCE_NAME AS sequence_name FROM ALL_SEQUENCES WHERE SEQUENCE_OWNER = '%s' ORDER BY SEQUENCE_NAME", strings.ToUpper(safeDbName))}} default: return nil } From 9ba3216fa877a6a20b30acfb83e0b2632c02796a Mon Sep 17 00:00:00 2001 From: Syngnat <92659908+Syngnat@users.noreply.github.com> Date: Wed, 8 Jul 2026 12:05:48 +0800 Subject: [PATCH 2/2] test(oceanbase): cover Oracle sequence metadata fallbacks --- .../app/methods_db_objects_sequence_test.go | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 internal/app/methods_db_objects_sequence_test.go diff --git a/internal/app/methods_db_objects_sequence_test.go b/internal/app/methods_db_objects_sequence_test.go new file mode 100644 index 00000000..bc3c7476 --- /dev/null +++ b/internal/app/methods_db_objects_sequence_test.go @@ -0,0 +1,39 @@ +package app + +import ( + "strings" + "testing" +) + +func TestBuildObjectSequenceMetadataQueriesOracleUsesWildcardAndObjectFallback(t *testing.T) { + t.Parallel() + + specs := buildObjectSequenceMetadataQueries("oracle", "sbdev") + if len(specs) != 2 { + t.Fatalf("expected 2 Oracle sequence metadata queries, got %d", len(specs)) + } + if !strings.Contains(specs[0].sql, "SELECT * FROM ALL_SEQUENCES") { + t.Fatalf("expected ALL_SEQUENCES wildcard query, got %q", specs[0].sql) + } + if strings.Contains(specs[0].sql, "LAST_NUMBER") || strings.Contains(specs[0].sql, "ORDER_FLAG") { + t.Fatalf("query should not enumerate optional sequence columns: %q", specs[0].sql) + } + if !strings.Contains(specs[1].sql, "ALL_OBJECTS") || !strings.Contains(specs[1].sql, "OBJECT_TYPE = 'SEQUENCE'") { + t.Fatalf("expected ALL_OBJECTS fallback query, got %q", specs[1].sql) + } +} + +func TestBuildObjectSequenceMetadataQueriesOracleUserFallbacks(t *testing.T) { + t.Parallel() + + specs := buildObjectSequenceMetadataQueries("oracle", "") + if len(specs) != 2 { + t.Fatalf("expected 2 Oracle user sequence metadata queries, got %d", len(specs)) + } + if specs[0].sql != "SELECT * FROM USER_SEQUENCES ORDER BY SEQUENCE_NAME" { + t.Fatalf("unexpected USER_SEQUENCES query: %q", specs[0].sql) + } + if !strings.Contains(specs[1].sql, "USER_OBJECTS") || !strings.Contains(specs[1].sql, "OBJECT_TYPE = 'SEQUENCE'") { + t.Fatalf("expected USER_OBJECTS fallback query, got %q", specs[1].sql) + } +}