mirror of
https://github.com/Syngnat/GoNavi.git
synced 2026-07-11 23:42:22 +08:00
Compare commits
7 Commits
fix/ci-qui
...
fix/oceanb
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c27a038fc5 | ||
|
|
c3c4efc6ec | ||
|
|
7a87d43bdc | ||
|
|
5fa1c90674 | ||
|
|
c79225ef27 | ||
|
|
0bd8fdea1f | ||
|
|
18dbd043ae |
@@ -26,6 +26,25 @@ describe('queryResultPagination', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('treats query-editor injected LIMIT as a capped page rather than an uncounted total', () => {
|
||||||
|
const page = createInitialQueryResultPagination({
|
||||||
|
executedSql: 'SELECT id, name FROM users LIMIT 500',
|
||||||
|
exportSql: 'SELECT id, name FROM users',
|
||||||
|
dbType: 'mysql',
|
||||||
|
returnedRowCount: 500,
|
||||||
|
fallbackPageSize: 500,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(page).toMatchObject({
|
||||||
|
current: 1,
|
||||||
|
pageSize: 500,
|
||||||
|
total: 500,
|
||||||
|
totalKnown: true,
|
||||||
|
baseSql: 'SELECT id, name FROM users',
|
||||||
|
exportAllSql: 'SELECT id, name FROM users',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
it('builds the next page SQL with one lookahead row', () => {
|
it('builds the next page SQL with one lookahead row', () => {
|
||||||
expect(buildQueryResultPageSql({
|
expect(buildQueryResultPageSql({
|
||||||
baseSql: 'SELECT id FROM users',
|
baseSql: 'SELECT id FROM users',
|
||||||
|
|||||||
@@ -22,6 +22,14 @@ const normalizePositiveInteger = (value: unknown): number => {
|
|||||||
return Number.isFinite(parsed) && parsed > 0 ? parsed : 0;
|
return Number.isFinite(parsed) && parsed > 0 ? parsed : 0;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const normalizeSqlForComparison = (sql: string): string => (
|
||||||
|
String(sql || '')
|
||||||
|
.replace(/\s+/g, ' ')
|
||||||
|
.replace(/;+\s*$/g, '')
|
||||||
|
.trim()
|
||||||
|
.toLowerCase()
|
||||||
|
);
|
||||||
|
|
||||||
const parseTopLevelLimit = (sql: string): LimitInfo | null => {
|
const parseTopLevelLimit = (sql: string): LimitInfo | null => {
|
||||||
const { main } = splitSqlTail(sql);
|
const { main } = splitSqlTail(sql);
|
||||||
const limitPos = findTopLevelKeyword(main, 'limit');
|
const limitPos = findTopLevelKeyword(main, 'limit');
|
||||||
@@ -60,6 +68,14 @@ const stripExplicitLimitForExport = (sql: string): string => {
|
|||||||
return splitSqlTail(sql).main.trim();
|
return splitSqlTail(sql).main.trim();
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const wasLimitAppliedByQueryEditorCap = (executedSql: string, exportSql: string): boolean => {
|
||||||
|
const executed = String(executedSql || '').trim();
|
||||||
|
const exportable = String(exportSql || '').trim();
|
||||||
|
if (!executed || !exportable) return false;
|
||||||
|
if (normalizeSqlForComparison(executed) === normalizeSqlForComparison(exportable)) return false;
|
||||||
|
return normalizeSqlForComparison(stripExplicitLimitForExport(executed)) === normalizeSqlForComparison(stripExplicitLimitForExport(exportable));
|
||||||
|
};
|
||||||
|
|
||||||
const resolveWrappedBaseSql = (dbType: string, baseSql: string): string => {
|
const resolveWrappedBaseSql = (dbType: string, baseSql: string): string => {
|
||||||
const normalizedType = String(dbType || '').trim().toLowerCase();
|
const normalizedType = String(dbType || '').trim().toLowerCase();
|
||||||
const base = baseSql.trim();
|
const base = baseSql.trim();
|
||||||
@@ -146,11 +162,14 @@ export const createInitialQueryResultPagination = (params: {
|
|||||||
const exportAllSql = exportSql && getLeadingKeyword(exportSql) === 'select'
|
const exportAllSql = exportSql && getLeadingKeyword(exportSql) === 'select'
|
||||||
? stripExplicitLimitForExport(exportSql)
|
? stripExplicitLimitForExport(exportSql)
|
||||||
: stripExplicitLimitForExport(executedSql);
|
: stripExplicitLimitForExport(executedSql);
|
||||||
const totalState = resolveQueryResultPaginationTotal({
|
const autoLimitCap = current === 1 && wasLimitAppliedByQueryEditorCap(executedSql, exportSql);
|
||||||
current,
|
const totalState = autoLimitCap
|
||||||
pageSize,
|
? { total: returnedRowCount, totalKnown: true }
|
||||||
rowCount: returnedRowCount,
|
: resolveQueryResultPaginationTotal({
|
||||||
});
|
current,
|
||||||
|
pageSize,
|
||||||
|
rowCount: returnedRowCount,
|
||||||
|
});
|
||||||
|
|
||||||
return {
|
return {
|
||||||
current,
|
current,
|
||||||
|
|||||||
Reference in New Issue
Block a user