mirror of
https://github.com/Syngnat/GoNavi.git
synced 2026-05-21 16:23:29 +08:00
c7cf9526de
- 密文存储：新增 dailysecret 本地存储引擎，连接/代理/AI 密钥不再依赖系统钥匙串 - 启动迁移：自动将已有钥匙串密文迁移到本地 JSON，用户无感知 - WebKit 迁移：从旧版 Wails WebKit LocalStorage 中恢复连接与代理数据 - DMG 修复：移除 --sandbox-safe 避免扩展属性污染签名，新增 xattr 清理与签名校验 - 安全适配：钥匙串不可用时标记完成而非回滚，消除无钥匙串环境下的阻塞 - 出口脱敏：所有连接/代理 API 返回前统一 sanitize 防止密文泄漏
395 lines
11 KiB
Go
395 lines
11 KiB
Go
package app
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"GoNavi-Wails/internal/connection"
|
|
)
|
|
|
|
func withTestGOOS(t *testing.T, goos string) {
|
|
t.Helper()
|
|
previous := runtimeGOOS
|
|
runtimeGOOS = func() string {
|
|
return goos
|
|
}
|
|
t.Cleanup(func() {
|
|
runtimeGOOS = previous
|
|
})
|
|
}
|
|
|
|
func TestSaveConnectionMethodReturnsSecretlessView(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
result, err := app.SaveConnection(connection.SavedConnectionInput{
|
|
ID: "conn-1",
|
|
Name: "Primary",
|
|
IncludeDatabases: []string{"appdb"},
|
|
IconType: "postgres",
|
|
IconColor: "#1677ff",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "conn-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "postgres-secret",
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if result.Config.Password != "" {
|
|
t.Fatal("SaveConnection must not return plaintext password")
|
|
}
|
|
if !result.HasPrimaryPassword {
|
|
t.Fatal("expected HasPrimaryPassword=true")
|
|
}
|
|
if !reflect.DeepEqual(result.IncludeDatabases, []string{"appdb"}) {
|
|
t.Fatalf("expected include databases to be preserved, got %#v", result.IncludeDatabases)
|
|
}
|
|
if result.IconType != "postgres" || result.IconColor != "#1677ff" {
|
|
t.Fatalf("expected icon metadata to be preserved, got type=%q color=%q", result.IconType, result.IconColor)
|
|
}
|
|
}
|
|
|
|
func TestSaveConnectionOnDarwinPersistsSecretsInlineButReturnsSecretlessView(t *testing.T) {
|
|
app := NewAppWithSecretStore(failOnUseSecretStore{})
|
|
app.configDir = t.TempDir()
|
|
|
|
result, err := app.SaveConnection(connection.SavedConnectionInput{
|
|
ID: "conn-darwin",
|
|
Name: "Primary",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "conn-darwin",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "postgres-secret",
|
|
DSN: "postgres://user:pass@db.local/app",
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if result.Config.Password != "" {
|
|
t.Fatal("SaveConnection must keep macOS return value secretless")
|
|
}
|
|
if result.Config.DSN != "" {
|
|
t.Fatal("SaveConnection must not return plaintext DSN")
|
|
}
|
|
if result.SecretRef != "" {
|
|
t.Fatalf("expected macOS inline persistence to avoid secret refs, got %q", result.SecretRef)
|
|
}
|
|
if !result.HasPrimaryPassword || !result.HasOpaqueDSN {
|
|
t.Fatalf("expected secret flags to stay true, got %#v", result)
|
|
}
|
|
|
|
raw, err := app.savedConnectionRepository().Find("conn-darwin")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if raw.Config.Password != "" {
|
|
t.Fatalf("expected raw saved connection metadata to stay secretless, got %q", raw.Config.Password)
|
|
}
|
|
if raw.Config.DSN != "" {
|
|
t.Fatalf("expected raw saved connection metadata to stay secretless, got %q", raw.Config.DSN)
|
|
}
|
|
if raw.SecretRef != "" {
|
|
t.Fatalf("expected raw saved connection to avoid secret refs, got %q", raw.SecretRef)
|
|
}
|
|
|
|
stored, ok, err := app.dailySecretStore().GetConnection("conn-darwin")
|
|
if err != nil {
|
|
t.Fatalf("GetConnection returned error: %v", err)
|
|
}
|
|
if !ok {
|
|
t.Fatal("expected daily secret store to keep saved connection secret")
|
|
}
|
|
if stored.Password != "postgres-secret" {
|
|
t.Fatalf("expected daily secret store to persist password, got %q", stored.Password)
|
|
}
|
|
if stored.OpaqueDSN != "postgres://user:pass@db.local/app" {
|
|
t.Fatalf("expected daily secret store to persist DSN, got %q", stored.OpaqueDSN)
|
|
}
|
|
}
|
|
|
|
func TestSaveConnectionClearsRequestedSecretFields(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
_, err := app.SaveConnection(connection.SavedConnectionInput{
|
|
ID: "conn-1",
|
|
Name: "Primary",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "conn-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "postgres-secret",
|
|
UseSSH: true,
|
|
SSH: connection.SSHConfig{
|
|
Host: "jump.local",
|
|
Port: 22,
|
|
User: "ops",
|
|
Password: "ssh-secret",
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
view, err := app.SaveConnection(connection.SavedConnectionInput{
|
|
ID: "conn-1",
|
|
Name: "Primary",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "conn-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
UseSSH: true,
|
|
SSH: connection.SSHConfig{
|
|
Host: "jump.local",
|
|
Port: 22,
|
|
User: "ops",
|
|
},
|
|
},
|
|
ClearPrimaryPassword: true,
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if view.HasPrimaryPassword {
|
|
t.Fatal("expected HasPrimaryPassword=false after clearing")
|
|
}
|
|
if !view.HasSSHPassword {
|
|
t.Fatal("expected SSH password to stay stored")
|
|
}
|
|
|
|
resolved, err := app.resolveConnectionSecrets(view.Config)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if resolved.Password != "" {
|
|
t.Fatalf("expected cleared primary password, got %q", resolved.Password)
|
|
}
|
|
if resolved.SSH.Password != "ssh-secret" {
|
|
t.Fatalf("expected SSH password to stay stored, got %q", resolved.SSH.Password)
|
|
}
|
|
}
|
|
|
|
func TestDuplicateConnectionClonesSecretBundle(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
_, err := app.SaveConnection(connection.SavedConnectionInput{
|
|
ID: "conn-1",
|
|
Name: "Primary",
|
|
IncludeDatabases: []string{"appdb"},
|
|
IncludeRedisDatabases: []int{0, 1},
|
|
IconType: "postgres",
|
|
IconColor: "#1677ff",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "conn-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "postgres-secret",
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
duplicate, err := app.DuplicateConnection("conn-1")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if duplicate.ID == "conn-1" {
|
|
t.Fatal("duplicate should have a new id")
|
|
}
|
|
if duplicate.Name != "Primary - 副本" {
|
|
t.Fatalf("expected duplicate name to keep existing UX, got %q", duplicate.Name)
|
|
}
|
|
if !reflect.DeepEqual(duplicate.IncludeDatabases, []string{"appdb"}) {
|
|
t.Fatalf("expected include databases to be cloned, got %#v", duplicate.IncludeDatabases)
|
|
}
|
|
if !reflect.DeepEqual(duplicate.IncludeRedisDatabases, []int{0, 1}) {
|
|
t.Fatalf("expected redis include databases to be cloned, got %#v", duplicate.IncludeRedisDatabases)
|
|
}
|
|
if duplicate.IconType != "postgres" || duplicate.IconColor != "#1677ff" {
|
|
t.Fatalf("expected icon metadata to be cloned, got type=%q color=%q", duplicate.IconType, duplicate.IconColor)
|
|
}
|
|
|
|
resolved, err := app.resolveConnectionSecrets(duplicate.Config)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if resolved.Password != "postgres-secret" {
|
|
t.Fatalf("expected duplicated secret bundle, got %q", resolved.Password)
|
|
}
|
|
}
|
|
|
|
func TestSaveGlobalProxyReturnsSecretlessView(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
view, err := app.SaveGlobalProxy(connection.SaveGlobalProxyInput{
|
|
Enabled: true,
|
|
Type: "http",
|
|
Host: "127.0.0.1",
|
|
Port: 8080,
|
|
User: "ops",
|
|
Password: "proxy-secret",
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if view.Password != "" {
|
|
t.Fatal("global proxy view must not expose plaintext password")
|
|
}
|
|
if !view.HasPassword {
|
|
t.Fatal("expected hasPassword=true")
|
|
}
|
|
}
|
|
|
|
func TestSaveGlobalProxyOnDarwinPersistsPasswordInlineButReturnsSecretlessView(t *testing.T) {
|
|
app := NewAppWithSecretStore(failOnUseSecretStore{})
|
|
app.configDir = t.TempDir()
|
|
|
|
view, err := app.SaveGlobalProxy(connection.SaveGlobalProxyInput{
|
|
Enabled: true,
|
|
Type: "http",
|
|
Host: "127.0.0.1",
|
|
Port: 8080,
|
|
User: "ops",
|
|
Password: "proxy-secret",
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if view.Password != "" {
|
|
t.Fatal("SaveGlobalProxy must not expose plaintext password")
|
|
}
|
|
if !view.HasPassword {
|
|
t.Fatal("expected hasPassword=true")
|
|
}
|
|
if view.SecretRef != "" {
|
|
t.Fatalf("expected proxy persistence to avoid secret refs, got %q", view.SecretRef)
|
|
}
|
|
|
|
stored, err := app.loadStoredGlobalProxyView()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if stored.Password != "" {
|
|
t.Fatalf("expected stored global proxy metadata to stay secretless, got %q", stored.Password)
|
|
}
|
|
if stored.SecretRef != "" {
|
|
t.Fatalf("expected stored global proxy to avoid secret refs, got %q", stored.SecretRef)
|
|
}
|
|
|
|
proxySecret, ok, err := app.dailySecretStore().GetGlobalProxy()
|
|
if err != nil {
|
|
t.Fatalf("GetGlobalProxy returned error: %v", err)
|
|
}
|
|
if !ok {
|
|
t.Fatal("expected daily secret store to keep proxy password")
|
|
}
|
|
if proxySecret.Password != "proxy-secret" {
|
|
t.Fatalf("expected daily secret store to persist proxy password, got %q", proxySecret.Password)
|
|
}
|
|
}
|
|
|
|
func TestImportLegacyConnectionsIsIdempotentForSameID(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
legacy := connection.LegacySavedConnection{
|
|
ID: "legacy-1",
|
|
Name: "Legacy",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "legacy-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "secret-1",
|
|
},
|
|
}
|
|
|
|
if _, err := app.ImportLegacyConnections([]connection.LegacySavedConnection{legacy}); err != nil {
|
|
t.Fatalf("first ImportLegacyConnections returned error: %v", err)
|
|
}
|
|
if _, err := app.ImportLegacyConnections([]connection.LegacySavedConnection{legacy}); err != nil {
|
|
t.Fatalf("second ImportLegacyConnections returned error: %v", err)
|
|
}
|
|
|
|
saved, err := app.GetSavedConnections()
|
|
if err != nil {
|
|
t.Fatalf("GetSavedConnections returned error: %v", err)
|
|
}
|
|
if len(saved) != 1 {
|
|
t.Fatalf("expected a single saved connection after repeated import, got %d", len(saved))
|
|
}
|
|
}
|
|
|
|
func TestImportLegacyConnectionsClearsExistingSecretWhenReimportOmitsPassword(t *testing.T) {
|
|
app := NewAppWithSecretStore(newFakeAppSecretStore())
|
|
app.configDir = t.TempDir()
|
|
|
|
if _, err := app.ImportLegacyConnections([]connection.LegacySavedConnection{
|
|
{
|
|
ID: "legacy-1",
|
|
Name: "Legacy",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "legacy-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
Password: "secret-1",
|
|
},
|
|
},
|
|
}); err != nil {
|
|
t.Fatalf("initial ImportLegacyConnections returned error: %v", err)
|
|
}
|
|
|
|
if _, err := app.ImportLegacyConnections([]connection.LegacySavedConnection{
|
|
{
|
|
ID: "legacy-1",
|
|
Name: "Legacy Updated",
|
|
Config: connection.ConnectionConfig{
|
|
ID: "legacy-1",
|
|
Type: "postgres",
|
|
Host: "db.local",
|
|
Port: 5432,
|
|
User: "postgres",
|
|
},
|
|
},
|
|
}); err != nil {
|
|
t.Fatalf("update ImportLegacyConnections returned error: %v", err)
|
|
}
|
|
|
|
saved, err := app.GetSavedConnections()
|
|
if err != nil {
|
|
t.Fatalf("GetSavedConnections returned error: %v", err)
|
|
}
|
|
if len(saved) != 1 {
|
|
t.Fatalf("expected 1 saved connection, got %d", len(saved))
|
|
}
|
|
resolved, err := app.resolveConnectionSecrets(saved[0].Config)
|
|
if err != nil {
|
|
t.Fatalf("resolveConnectionSecrets returned error: %v", err)
|
|
}
|
|
if resolved.Password != "" {
|
|
t.Fatalf("expected missing import password to clear existing secret, got %q", resolved.Password)
|
|
}
|
|
}
|