mirror of
https://github.com/krau/SaveAny-Bot.git
synced 2026-09-01 21:56:41 +08:00
* fix: prevent queue deadlock after cancelling tasks Get no longer recurses while holding the mutex. Cancelled queued tasks leave the map, making their IDs reusable. Closed empty queues return ErrQueueClosed. * fix: init task queue lazily and close on shutdown AddTask is safe before Run by initializing the queue once. Close unblocks workers waiting in Get. * fix: make resource fingerprints deterministic Sort map keys before hashing so Resource.ID is stable. * fix: harden per-item processing tracking in tasks Use the resource fingerprint as the dedup key on insert and delete. Check and set processing entries atomically instead of TOCTOU. Count only successful downloads. * fix: honor IgnoreErrors in batch tasks Element failures no longer cancel sibling elements or stop later groups. * fix: report streamed upload bytes in batch tasks Stream downloads report their byte count as the upload total. * fix: validate i18n key parity across locales geni18n fails when a language file misses any key. Align the syncpeers completion key between en and zh-Hans. Translate three untranslated parse keys in zh-Hans. * refactor: share progress throttling helpers Move size-tiered and count-based throttling into progressutil. Localize hardcoded Chinese progress strings. Drop five duplicated implementations and dead local copies. * refactor: share unique filename logic Storage backends use fsutil.UniquePath instead of local loops. * fix: sanitize local storage paths Reject absolute paths and dot-dot escapes in Save. Check close errors and wrap creation failures. * fix: preserve webdav error causes Wrap mkdir and write failures with %w and drop dead error values. * fix: kill rclone subprocess on reader close Prevent cat processes from hanging after the pipe is closed. * fix: fail alist init instead of exiting Replace log.Fatalf with wrapped errors so a bad alist cannot kill the bot. Cancel token refresh with the init context and re-login on 401. * fix: enforce telegram album limits and track saved paths Use tglimit.MaxAlbumItems for album batching and video splitting. Exists now reports previously saved paths instead of always false. * fix: guard storage registry maps Protect Storages and UserStorages with mutexes and expose read accessors. * fix: harden JS parser plugin runtime Validate semver instead of panicking and require canHandle. Recover plugin worker panics and time out CanHandle calls. Return a copy from the registry and sanitize install filenames. * fix: guard kemono parser against nil fields Skip sparse preview and attachment entries instead of panicking. * refactor: remove commented-out dead code Drop unused kemono legacy types and commented response structs. * test: cover invalid plugin version rejection * fix: show all queued tasks in /task list Render up to ten tasks and append the truncation note once. * fix: guard callback data parsing Reject malformed callback payloads before indexing split parts. * fix: isolate media groups per user Key pending groups by chat, user and group id. * fix: require permission for callback handlers * fix: initialize userbot context once Replace the racy lazy init with sync.OnceValue. * fix: avoid leaking raw errors in /dir reply * fix: notify users on invalid update version * fix: fail fast when API listen fails Bind synchronously and surface errors instead of logging them. * fix: add timeouts and backoff to webhook delivery * refactor: remove dead code from api and bot Drop the empty ProgressTracker shim, unused token context key and a redundant SetBotCommands call. * fix: load remote config without local lookup Skip the local file search after reading a config URL and add a timeout. * refactor: drop unused hook config * docs: document parser plugin config * ci: fix BuildTime formatting and align checkout Actions format does not format dates; pass the raw timestamp. * chore: ignore cache directory * fix: make cache init idempotent * fix: upload only downloaded batch elements Failed elements keep partial cache files and never reach the backend. Successfully downloaded siblings still upload when one element fails. * fix: record telegram saved paths only after upload Skip-large returns a sentinel so skipped files are not marked as saved. * fix: deduplicate alist token refreshes Guard token access with a mutex and merge concurrent logins. Reuse a recent refresh to avoid login storms. * test: cover concurrent alist 401 retry Ten parallel uploads share a single re-login under -race. * fix: count parsed resources in progress text * fix: localize storage lookup errors in /dir Use the shared i18n key and escape the dynamic error. * fix: deduplicate concurrent storage initialization singleflight merges first-time inits so side effects are not duplicated. * fix: guard nil progress trackers in api-created tasks Batch, telegraph and transfer tasks run without a Telegram tracker when created through the API; their callbacks must not panic. * fix: keep album order when filtering failed batch items Download results are stored by original index so surviving elements keep their source order. * test: cover nil-tracker task execution * fix: report partial failure in batch done message IgnoreErrors runs with failed elements show success and failed counts instead of claiming every file completed. * fix: skip login refresh for token-only alist storage 401 responses surface the auth error instead of sending a credential-less login; the refresh window never exceeds TokenExp. * test: cover alist refresh semantics Concurrent refresh uses username/password; token-only storage never attempts a login on 401. * fix: call tracker from notifyProgress instead of recursing The helper called itself, overflowing the stack on any batch task with a progress tracker. * fix: propagate cancellation past IgnoreErrors Cancelled tasks must not be reported as successful: only ordinary element failures are ignored. * test: cover notifyProgress tracker call * test: cover cancellation with IgnoreErrors * fix: refresh alist token after startup 401s The init login no longer satisfies the dedup window, so an early 401 triggers a real refresh; later 401s reuse it. Clarify that streaming uploads cannot replay their body. * test: exercise the alist 401 refresh path Concurrent uploads now reject the init token, share one refresh and retry with the new token; token-only stays inert. * style: trim verbose comments Drop process-style explanations; keep one-line behavior notes. * style: gofmt test files * fix: drop unbounded saved-path cache in telegram storage Telegram cannot reliably query remote file existence, so the cache answered a question it could not answer and grew without bound. Exists returns false again, as before. * style: format codes
210 lines
5.2 KiB
Go
210 lines
5.2 KiB
Go
//go:build !no_jsparser
|
|
|
|
package js
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/charmbracelet/log"
|
|
"github.com/dop251/goja"
|
|
"github.com/krau/SaveAny-Bot/config"
|
|
"github.com/krau/SaveAny-Bot/pkg/parser"
|
|
)
|
|
|
|
type jsParser struct {
|
|
meta PluginMeta
|
|
vm *goja.Runtime
|
|
reqCh chan jsParserReq
|
|
}
|
|
|
|
type jsParserReq struct {
|
|
method ParserMethod
|
|
url string
|
|
respCh chan jsParserResp
|
|
}
|
|
|
|
type jsParserResp struct {
|
|
item *parser.Item
|
|
ok bool
|
|
err error
|
|
}
|
|
|
|
const canHandleTimeout = 10 * time.Second
|
|
|
|
func (p *jsParser) CanHandle(url string) bool {
|
|
respCh := make(chan jsParserResp, 1)
|
|
timer := time.NewTimer(canHandleTimeout)
|
|
defer timer.Stop()
|
|
select {
|
|
case p.reqCh <- jsParserReq{method: ParserMethodCanHandle, url: url, respCh: respCh}:
|
|
case <-timer.C:
|
|
return false
|
|
}
|
|
select {
|
|
case resp := <-respCh:
|
|
return resp.ok && resp.err == nil
|
|
case <-timer.C:
|
|
return false
|
|
}
|
|
}
|
|
|
|
func (p *jsParser) Parse(ctx context.Context, url string) (*parser.Item, error) {
|
|
respCh := make(chan jsParserResp, 1)
|
|
p.reqCh <- jsParserReq{method: ParserMethodParse, url: url, respCh: respCh}
|
|
select {
|
|
case resp := <-respCh:
|
|
return resp.item, resp.err
|
|
case <-ctx.Done():
|
|
return nil, ctx.Err()
|
|
}
|
|
}
|
|
|
|
func newJSParser(vm *goja.Runtime, canHandleFunc, parseFunc goja.Value, metadata PluginMeta) *jsParser {
|
|
p := &jsParser{
|
|
vm: vm,
|
|
reqCh: make(chan jsParserReq, 10),
|
|
meta: metadata,
|
|
}
|
|
|
|
go func() {
|
|
for req := range p.reqCh {
|
|
func() {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
log.Errorf("JS parser %q panicked while handling method %d: %v", p.meta.Name, req.method, r)
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("JS parser %q panicked: %v", p.meta.Name, r)}
|
|
}
|
|
}()
|
|
switch req.method {
|
|
case ParserMethodCanHandle:
|
|
fn, ok := goja.AssertFunction(canHandleFunc)
|
|
if !ok {
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("canHandle is not a function")}
|
|
return
|
|
}
|
|
res, err := fn(goja.Undefined(), p.vm.ToValue(req.url))
|
|
if err != nil {
|
|
req.respCh <- jsParserResp{ok: false, err: err}
|
|
return
|
|
}
|
|
req.respCh <- jsParserResp{ok: res.ToBoolean()}
|
|
case ParserMethodParse:
|
|
fn, ok := goja.AssertFunction(parseFunc)
|
|
if !ok {
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("parse is not a function")}
|
|
return
|
|
}
|
|
result, err := fn(goja.Undefined(), p.vm.ToValue(req.url))
|
|
if err != nil {
|
|
req.respCh <- jsParserResp{err: err}
|
|
return
|
|
}
|
|
|
|
var item parser.Item
|
|
if exported := result.Export(); exported != nil {
|
|
data, err := json.Marshal(exported)
|
|
if err != nil {
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("failed to marshal result to JSON: %w", err)}
|
|
return
|
|
}
|
|
|
|
if err := json.Unmarshal(data, &item); err != nil {
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("failed to unmarshal JSON to Item: %w", err)}
|
|
return
|
|
}
|
|
} else {
|
|
req.respCh <- jsParserResp{err: fmt.Errorf("JS function returned null or undefined")}
|
|
return
|
|
}
|
|
req.respCh <- jsParserResp{item: &item}
|
|
}
|
|
}()
|
|
}
|
|
}()
|
|
|
|
return p
|
|
}
|
|
|
|
// 加载指定文件夹下的所有 JS 解析器插件
|
|
func LoadPlugins(ctx context.Context, dir string) error {
|
|
entries, err := os.ReadDir(dir)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, e := range entries {
|
|
if filepath.Ext(e.Name()) != ".js" {
|
|
continue
|
|
}
|
|
scriptPath := filepath.Join(dir, e.Name())
|
|
code, err := os.ReadFile(scriptPath)
|
|
if err != nil {
|
|
log.Warnf("Failed to read plugin file %s: %v", e.Name(), err)
|
|
continue
|
|
}
|
|
|
|
vm := goja.New()
|
|
vm.Set("registerParser", jsRegisterParser(vm))
|
|
// Inject some utils to vm
|
|
logger := log.FromContext(ctx).WithPrefix(fmt.Sprintf("[plugin|parser]/%s", e.Name()))
|
|
vm.Set("console", jsConsole(logger))
|
|
// http fetch funcs
|
|
vm.Set("ghttp", jsGhttp(vm))
|
|
// playwright fetch func
|
|
vm.Set("playwright", jsPlaywright(vm, logger))
|
|
|
|
if _, err := vm.RunString(string(code)); err != nil {
|
|
logger.Warnf("Failed to load plugin %s: %v", e.Name(), err)
|
|
continue
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
var (
|
|
pluginNameMu sync.Map
|
|
)
|
|
|
|
func AddPlugin(ctx context.Context, code string, name string) error {
|
|
value, _ := pluginNameMu.LoadOrStore(name, &sync.Mutex{})
|
|
mu := value.(*sync.Mutex)
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
|
|
return addPlugin(ctx, code, name)
|
|
}
|
|
|
|
func addPlugin(ctx context.Context, code string, name string) error {
|
|
logger := log.FromContext(ctx).WithPrefix(fmt.Sprintf("[plugin|parser]/%s", name))
|
|
vm := goja.New()
|
|
vm.Set("registerParser", jsRegisterParser(vm))
|
|
vm.Set("console", jsConsole(logger))
|
|
vm.Set("ghttp", jsGhttp(vm))
|
|
vm.Set("playwright", jsPlaywright(vm, logger))
|
|
if _, err := vm.RunString(code); err != nil {
|
|
return fmt.Errorf("error loading plugin %s: %w", name, err)
|
|
}
|
|
dir := "plugins"
|
|
configuredDirs := config.C().Parser.PluginDirs
|
|
if len(configuredDirs) > 0 {
|
|
dir = configuredDirs[0]
|
|
}
|
|
fileName := filepath.Base(name)
|
|
if fileName == "" || fileName == "." || fileName == ".." {
|
|
return fmt.Errorf("invalid plugin name %q", name)
|
|
}
|
|
if err := os.MkdirAll(dir, 0755); err == nil {
|
|
pluginPath := filepath.Join(dir, fileName)
|
|
if err := os.WriteFile(pluginPath, []byte(code), 0644); err != nil {
|
|
logger.Warn("Failed to save plugin file: " + err.Error())
|
|
}
|
|
}
|
|
return nil
|
|
}
|