mirror of
https://github.com/krau/SaveAny-Bot.git
synced 2026-08-29 20:26:42 +08:00
* fix: prevent queue deadlock after cancelling tasks Get no longer recurses while holding the mutex. Cancelled queued tasks leave the map, making their IDs reusable. Closed empty queues return ErrQueueClosed. * fix: init task queue lazily and close on shutdown AddTask is safe before Run by initializing the queue once. Close unblocks workers waiting in Get. * fix: make resource fingerprints deterministic Sort map keys before hashing so Resource.ID is stable. * fix: harden per-item processing tracking in tasks Use the resource fingerprint as the dedup key on insert and delete. Check and set processing entries atomically instead of TOCTOU. Count only successful downloads. * fix: honor IgnoreErrors in batch tasks Element failures no longer cancel sibling elements or stop later groups. * fix: report streamed upload bytes in batch tasks Stream downloads report their byte count as the upload total. * fix: validate i18n key parity across locales geni18n fails when a language file misses any key. Align the syncpeers completion key between en and zh-Hans. Translate three untranslated parse keys in zh-Hans. * refactor: share progress throttling helpers Move size-tiered and count-based throttling into progressutil. Localize hardcoded Chinese progress strings. Drop five duplicated implementations and dead local copies. * refactor: share unique filename logic Storage backends use fsutil.UniquePath instead of local loops. * fix: sanitize local storage paths Reject absolute paths and dot-dot escapes in Save. Check close errors and wrap creation failures. * fix: preserve webdav error causes Wrap mkdir and write failures with %w and drop dead error values. * fix: kill rclone subprocess on reader close Prevent cat processes from hanging after the pipe is closed. * fix: fail alist init instead of exiting Replace log.Fatalf with wrapped errors so a bad alist cannot kill the bot. Cancel token refresh with the init context and re-login on 401. * fix: enforce telegram album limits and track saved paths Use tglimit.MaxAlbumItems for album batching and video splitting. Exists now reports previously saved paths instead of always false. * fix: guard storage registry maps Protect Storages and UserStorages with mutexes and expose read accessors. * fix: harden JS parser plugin runtime Validate semver instead of panicking and require canHandle. Recover plugin worker panics and time out CanHandle calls. Return a copy from the registry and sanitize install filenames. * fix: guard kemono parser against nil fields Skip sparse preview and attachment entries instead of panicking. * refactor: remove commented-out dead code Drop unused kemono legacy types and commented response structs. * test: cover invalid plugin version rejection * fix: show all queued tasks in /task list Render up to ten tasks and append the truncation note once. * fix: guard callback data parsing Reject malformed callback payloads before indexing split parts. * fix: isolate media groups per user Key pending groups by chat, user and group id. * fix: require permission for callback handlers * fix: initialize userbot context once Replace the racy lazy init with sync.OnceValue. * fix: avoid leaking raw errors in /dir reply * fix: notify users on invalid update version * fix: fail fast when API listen fails Bind synchronously and surface errors instead of logging them. * fix: add timeouts and backoff to webhook delivery * refactor: remove dead code from api and bot Drop the empty ProgressTracker shim, unused token context key and a redundant SetBotCommands call. * fix: load remote config without local lookup Skip the local file search after reading a config URL and add a timeout. * refactor: drop unused hook config * docs: document parser plugin config * ci: fix BuildTime formatting and align checkout Actions format does not format dates; pass the raw timestamp. * chore: ignore cache directory * fix: make cache init idempotent * fix: upload only downloaded batch elements Failed elements keep partial cache files and never reach the backend. Successfully downloaded siblings still upload when one element fails. * fix: record telegram saved paths only after upload Skip-large returns a sentinel so skipped files are not marked as saved. * fix: deduplicate alist token refreshes Guard token access with a mutex and merge concurrent logins. Reuse a recent refresh to avoid login storms. * test: cover concurrent alist 401 retry Ten parallel uploads share a single re-login under -race. * fix: count parsed resources in progress text * fix: localize storage lookup errors in /dir Use the shared i18n key and escape the dynamic error. * fix: deduplicate concurrent storage initialization singleflight merges first-time inits so side effects are not duplicated. * fix: guard nil progress trackers in api-created tasks Batch, telegraph and transfer tasks run without a Telegram tracker when created through the API; their callbacks must not panic. * fix: keep album order when filtering failed batch items Download results are stored by original index so surviving elements keep their source order. * test: cover nil-tracker task execution * fix: report partial failure in batch done message IgnoreErrors runs with failed elements show success and failed counts instead of claiming every file completed. * fix: skip login refresh for token-only alist storage 401 responses surface the auth error instead of sending a credential-less login; the refresh window never exceeds TokenExp. * test: cover alist refresh semantics Concurrent refresh uses username/password; token-only storage never attempts a login on 401. * fix: call tracker from notifyProgress instead of recursing The helper called itself, overflowing the stack on any batch task with a progress tracker. * fix: propagate cancellation past IgnoreErrors Cancelled tasks must not be reported as successful: only ordinary element failures are ignored. * test: cover notifyProgress tracker call * test: cover cancellation with IgnoreErrors * fix: refresh alist token after startup 401s The init login no longer satisfies the dedup window, so an early 401 triggers a real refresh; later 401s reuse it. Clarify that streaming uploads cannot replay their body. * test: exercise the alist 401 refresh path Concurrent uploads now reject the init token, share one refresh and retry with the new token; token-only stays inert. * style: trim verbose comments Drop process-style explanations; keep one-line behavior notes. * style: gofmt test files * fix: drop unbounded saved-path cache in telegram storage Telegram cannot reliably query remote file existence, so the cache answered a question it could not answer and grew without bound. Exists returns false again, as before. * style: format codes
178 lines
4.3 KiB
Go
178 lines
4.3 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/charmbracelet/log"
|
|
"github.com/krau/SaveAny-Bot/config"
|
|
)
|
|
|
|
// Server API 服务器
|
|
type Server struct {
|
|
httpServer *http.Server
|
|
factory *TaskFactory
|
|
}
|
|
|
|
// NewServer 创建新的 API 服务器
|
|
func NewServer(ctx context.Context) *Server {
|
|
cfg := config.C().API
|
|
|
|
factory := NewTaskFactory(ctx)
|
|
handlers := NewHandlers(factory)
|
|
|
|
// 设置路由
|
|
mux := http.NewServeMux()
|
|
|
|
// 健康检查
|
|
mux.HandleFunc("/health", handlers.HealthCheckHandler)
|
|
|
|
// API v1 路由
|
|
mux.HandleFunc("/api/v1/tasks", func(w http.ResponseWriter, r *http.Request) {
|
|
switch r.Method {
|
|
case http.MethodGet:
|
|
handlers.ListTasksHandler(w, r)
|
|
case http.MethodPost:
|
|
handlers.CreateTaskHandler(w, r)
|
|
default:
|
|
MethodNotAllowedHandler(w, r)
|
|
}
|
|
})
|
|
mux.HandleFunc("/api/v1/tasks/", func(w http.ResponseWriter, r *http.Request) {
|
|
// 根据方法和路径分发
|
|
switch r.Method {
|
|
case http.MethodGet:
|
|
handlers.GetTaskHandler(w, r)
|
|
case http.MethodDelete:
|
|
handlers.CancelTaskHandler(w, r)
|
|
default:
|
|
MethodNotAllowedHandler(w, r)
|
|
}
|
|
})
|
|
mux.HandleFunc("/api/v1/storages", handlers.ListStoragesHandler)
|
|
mux.HandleFunc("/api/v1/task-types", handlers.GetTaskTypesHandler)
|
|
|
|
// 404 处理
|
|
mux.HandleFunc("/", NotFoundHandler)
|
|
|
|
// Apply middleware chain.
|
|
var handler http.Handler = mux
|
|
|
|
// Apply auth middleware when a token is configured.
|
|
token := cfg.Token
|
|
if token != "" {
|
|
handler = AuthMiddleware()(handler)
|
|
}
|
|
|
|
// Add logging middleware.
|
|
handler = loggingMiddleware(handler)
|
|
|
|
// Add recovery middleware.
|
|
handler = recoveryMiddleware(handler)
|
|
|
|
return &Server{
|
|
httpServer: &http.Server{
|
|
Addr: fmt.Sprintf("%s:%d", cfg.Host, cfg.Port),
|
|
Handler: handler,
|
|
ReadTimeout: 30 * time.Second,
|
|
WriteTimeout: 30 * time.Second,
|
|
IdleTimeout: 120 * time.Second,
|
|
},
|
|
factory: factory,
|
|
}
|
|
}
|
|
|
|
// Start 启动服务器
|
|
func (s *Server) Start(ctx context.Context) error {
|
|
logger := log.FromContext(ctx).With("module", "api")
|
|
|
|
logger.Infof("Starting API server on %s", s.httpServer.Addr)
|
|
|
|
// Bind synchronously so listen failures are returned to the caller.
|
|
ln, err := net.Listen("tcp", s.httpServer.Addr)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to listen on %s: %w", s.httpServer.Addr, err)
|
|
}
|
|
|
|
// 在 goroutine 中启动服务器
|
|
go func() {
|
|
if err := s.httpServer.Serve(ln); err != nil && err != http.ErrServerClosed {
|
|
logger.Errorf("API server error: %v", err)
|
|
}
|
|
}()
|
|
|
|
// 监听 context 取消
|
|
go func() {
|
|
<-ctx.Done()
|
|
shutdownCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
|
|
defer cancel()
|
|
if err := s.httpServer.Shutdown(shutdownCtx); err != nil {
|
|
logger.Errorf("API server shutdown error: %v", err)
|
|
}
|
|
}()
|
|
|
|
return nil
|
|
}
|
|
|
|
// loggingMiddleware 日志中间件
|
|
func loggingMiddleware(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
start := time.Now()
|
|
|
|
// 包装 ResponseWriter 以获取状态码
|
|
wrapped := &responseWriter{ResponseWriter: w, statusCode: http.StatusOK}
|
|
|
|
next.ServeHTTP(wrapped, r)
|
|
|
|
log.Infof("%s %s %d %s", r.Method, r.URL.Path, wrapped.statusCode, time.Since(start))
|
|
})
|
|
}
|
|
|
|
// recoveryMiddleware 恢复中间件
|
|
func recoveryMiddleware(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
log.Errorf("Panic recovered: %v", err)
|
|
WriteError(w, http.StatusInternalServerError, "internal_error", "internal server error")
|
|
}
|
|
}()
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
// responseWriter 包装 http.ResponseWriter 以捕获状态码
|
|
type responseWriter struct {
|
|
http.ResponseWriter
|
|
statusCode int
|
|
}
|
|
|
|
func (rw *responseWriter) WriteHeader(code int) {
|
|
rw.statusCode = code
|
|
rw.ResponseWriter.WriteHeader(code)
|
|
}
|
|
|
|
// Start initializes and starts the API server. It refuses to start without a
|
|
// token, since an open download proxy is a security risk.
|
|
func Start(ctx context.Context) error {
|
|
cfg := config.C().API
|
|
|
|
if !cfg.Enable {
|
|
return nil
|
|
}
|
|
|
|
if cfg.Token == "" {
|
|
return fmt.Errorf("API server is enabled but no token is set; refusing to start insecurely")
|
|
}
|
|
|
|
server := NewServer(ctx)
|
|
if err := server.Start(ctx); err != nil {
|
|
return err
|
|
}
|
|
StartCleanupLoop(ctx)
|
|
return nil
|
|
}
|