From 8568dd0d2ab051f7af280d271eb36bec781a495e Mon Sep 17 00:00:00 2001 From: "cursor[bot]" <206951365+cursor[bot]@users.noreply.github.com> Date: Thu, 28 May 2026 07:27:51 +0800 Subject: [PATCH] fix(dashboard): prevent superseded dashboard loads from mutating state (#301) Adds two loadSeq guards in _loadDashboardDataInner: after the first await coreP and before the self-heal writeOpenclawConfig path. Prevents stale loads from polluting cache, popping toasts, or writing config after a newer load has been queued. --- src/pages/dashboard.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/pages/dashboard.js b/src/pages/dashboard.js index ba40413..6028da5 100644 --- a/src/pages/dashboard.js +++ b/src/pages/dashboard.js @@ -219,7 +219,7 @@ function normalizeDefaultModelConfig(config) { } async function loadDashboardData(page, fullRefresh = false) { - // 并发保护:如果上一次加载仍在进行,跳过本次(fullRefresh 除外) + // 将多次触发串行化到同一链上;_dashboardLoadSeq 在排队时就会递增,供 inner 丢弃过期结果 const loadSeq = ++_dashboardLoadSeq _dashboardLoadChain = _dashboardLoadChain.catch(() => {}).then(() => _loadDashboardDataInner(page, fullRefresh, loadSeq)) return _dashboardLoadChain @@ -246,6 +246,8 @@ async function _loadDashboardDataInner(page, fullRefresh, loadSeq) { // 第一波:服务状态 + 配置 + 版本 → 立即渲染统计卡片 const [servicesRes, configRes, panelConfigRes] = await coreP + // 排队期间可能已发起更新的加载:勿用淘汰中的结果改缓存、弹 toast 或写配置(避免与较新加载竞态) + if (loadSeq !== _dashboardLoadSeq || !page.isConnected) return const services = servicesRes.status === 'fulfilled' ? servicesRes.value : [] let version = _dashboardVersionCache || {} let config = configRes.status === 'fulfilled' ? configRes.value : null @@ -273,6 +275,7 @@ async function _loadDashboardDataInner(page, fullRefresh, loadSeq) { if (needsPatch) { try { const freshConfig = await api.readOpenclawConfig() + if (loadSeq !== _dashboardLoadSeq || !page.isConnected) return let patched = false if (!freshConfig.gateway) freshConfig.gateway = {} if (!freshConfig.gateway.mode) { freshConfig.gateway.mode = 'local'; patched = true }