GithubBackup/geekgeekrun
1
0
Fork 0
mirror of https://github.com/geekgeekrun/geekgeekrun.git synced 2026-09-09 01:17:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor the is.dev to process.env.NODE_ENV === 'development'

Browse Source
This commit is contained in:
geekgeekrun
2024-03-05 10:02:49 +08:00
parent 9a7aa8e3ab
commit b4e3c17f9e
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/main/flow/CHECK_AND_DOWNLOAD_DEPENDENCIES/check-and-download-puppeteer-executable.ts
+1 -2
View File
@@ -2,7 +2,6 @@ import * as path from 'node:path'
import * as os from 'node:os' import * as os from 'node:os'
import * as fs from 'node:fs' import * as fs from 'node:fs'
import type { InstalledBrowser } from '@puppeteer/browsers' import type { InstalledBrowser } from '@puppeteer/browsers'
import { is } from '@electron-toolkit/utils'
import electron from 'electron' import electron from 'electron'
import { saveLastUsedAndAvailableBrowserInfo, BrowserInfo } from './history-utils' import { saveLastUsedAndAvailableBrowserInfo, BrowserInfo } from './history-utils'
@@ -15,7 +14,7 @@ const cacheDir = path.join(
const getPuppeteerManagerModule = async () => { const getPuppeteerManagerModule = async () => {
let puppeteerManager let puppeteerManager
if (is.dev) { if (process.env.NODE_ENV === 'development') {
puppeteerManager = await import('@puppeteer/browsers') puppeteerManager = await import('@puppeteer/browsers')
} else { } else {
puppeteerManager = ( puppeteerManager = (
packages/ui/src/main/flow/CHECK_AND_DOWNLOAD_DEPENDENCIES/check-and-locate-existed-chromium-executable.ts
+1 -2
View File
@@ -1,4 +1,3 @@
import { is } from '@electron-toolkit/utils'
import electron from 'electron' import electron from 'electron'
import * as os from 'node:os' import * as os from 'node:os'
import * as fs from 'node:fs' import * as fs from 'node:fs'
@@ -39,7 +38,7 @@ export default async function findAndLocateExistedChromiumExecutable(): Promise<
// For other, use findChrome // For other, use findChrome
let findChrome: typeof import('find-chrome-bin').findChrome let findChrome: typeof import('find-chrome-bin').findChrome
if (is.dev) { if (process.env.NODE_ENV === 'development') {
findChrome = (await import('find-chrome-bin')).findChrome findChrome = (await import('find-chrome-bin')).findChrome
} else { } else {
findChrome = ( findChrome = (
packages/ui/src/main/window/mainWindow.ts
+2 -3
View File
@@ -1,7 +1,6 @@
import { BrowserWindow, ipcMain, shell } from 'electron' import { BrowserWindow, ipcMain, shell } from 'electron'
import path from 'path' import path from 'path'
import * as childProcess from 'node:child_process' import * as childProcess from 'node:child_process'
import { is } from '@electron-toolkit/utils'
import { import {
ensureConfigFileExist, ensureConfigFileExist,
ensureStorageFileExist, ensureStorageFileExist,
@@ -40,7 +39,7 @@ export function createMainWindow(): void {
} }
}) })
is.dev && mainWindow.webContents.openDevTools() process.env.NODE_ENV === 'development' && mainWindow.webContents.openDevTools()
mainWindow.on('ready-to-show', () => { mainWindow.on('ready-to-show', () => {
mainWindow.show() mainWindow.show()
@@ -53,7 +52,7 @@ export function createMainWindow(): void {
// HMR for renderer base on electron-vite cli. // HMR for renderer base on electron-vite cli.
// Load the remote URL for development or the local html file for production. // Load the remote URL for development or the local html file for production.
if (is.dev && process.env['ELECTRON_RENDERER_URL']) { if (process.env.NODE_ENV === 'development' && process.env['ELECTRON_RENDERER_URL']) {
mainWindow.loadURL(process.env['ELECTRON_RENDERER_URL']) mainWindow.loadURL(process.env['ELECTRON_RENDERER_URL'])
} else { } else {
mainWindow.loadFile(path.join(__dirname, '../renderer/index.html')) mainWindow.loadFile(path.join(__dirname, '../renderer/index.html'))