From 08849850f92fb643d90c2e46b108d06bd5c45ba4 Mon Sep 17 00:00:00 2001
From: "lilong.129" <lilong.129@bytedance.com>
Date: Wed, 6 Aug 2025 11:42:22 +0800
Subject: [PATCH] feat: add gadb pull folder/file

---
 .github/workflows/smoketest.yml |  8 ++++++
 .github/workflows/unittest.yml  |  8 +++++-
 .gitignore                      |  4 +++
 internal/version/VERSION        |  2 +-
 pkg/gadb/device.go              | 49 +++++++++++++++++++++++++++++++++
 pkg/gadb/device_test.go         | 11 ++++++++
 6 files changed, 80 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/smoketest.yml b/.github/workflows/smoketest.yml
index 83df9a2b..c0a79a20 100644
--- a/.github/workflows/smoketest.yml
+++ b/.github/workflows/smoketest.yml
@@ -24,8 +24,16 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: ${{ matrix.go-version }}
+      - name: Install Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.9'
       - name: Checkout code
         uses: actions/checkout@v2
+      - name: Install Python dependencies
+        run: |
+          python3 -m pip install --upgrade pip
+          python3 -m pip install funppy httprunner
       - name: Build hrp binary
         run: make build
       - name: Run smoketest - run with parameters
diff --git a/.github/workflows/unittest.yml b/.github/workflows/unittest.yml
index 0a854858..55ce8434 100644
--- a/.github/workflows/unittest.yml
+++ b/.github/workflows/unittest.yml
@@ -23,8 +23,14 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: ${{ matrix.go-version }}
+      - name: Install Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.9'
       - name: Install Python plugin dependencies
-        run: python3 -m pip install funppy
+        run: |
+          python3 -m pip install --upgrade pip
+          python3 -m pip install funppy httprunner
       - name: Checkout code
         uses: actions/checkout@v2
       - name: Run coverage
diff --git a/.gitignore b/.gitignore
index b2daa1e9..8a25c14f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,3 +45,7 @@ dist
 *.egg-info
 .python-version
 .pytest_cache
+
+# generated go module files in templates
+internal/scaffold/templates/plugin/go.mod
+internal/scaffold/templates/plugin/go.sum
diff --git a/internal/version/VERSION b/internal/version/VERSION
index 0abffd80..77429189 100644
--- a/internal/version/VERSION
+++ b/internal/version/VERSION
@@ -1 +1 @@
-v5.0.0-250803
+v5.0.0-250806
diff --git a/pkg/gadb/device.go b/pkg/gadb/device.go
index e6cd5aed..c6857fee 100644
--- a/pkg/gadb/device.go
+++ b/pkg/gadb/device.go
@@ -610,6 +610,55 @@ func (d *Device) Pull(remotePath string, dest io.Writer) (err error) {
 	return
 }
 
+func (d *Device) PullFolder(remotePath string, localPath string) (err error) {
+	// Check if remote path exists and is a directory
+	fileInfos, err := d.List(remotePath)
+	if err != nil {
+		return fmt.Errorf("failed to list remote directory: %w", err)
+	}
+
+	// Create local directory if it doesn't exist
+	if err = os.MkdirAll(localPath, 0o755); err != nil {
+		return fmt.Errorf("failed to create local directory: %w", err)
+	}
+
+	// Pull each file/directory recursively
+	for _, fileInfo := range fileInfos {
+		remoteItemPath := remotePath + "/" + fileInfo.Name
+		localItemPath := localPath + "/" + fileInfo.Name
+
+		if fileInfo.IsDir() {
+			// Recursively pull subdirectory
+			if err = d.PullFolder(remoteItemPath, localItemPath); err != nil {
+				return fmt.Errorf("failed to pull subdirectory %s: %w", remoteItemPath, err)
+			}
+		} else {
+			// Pull file
+			if err = d.PullFile(remoteItemPath, localItemPath); err != nil {
+				return fmt.Errorf("failed to pull file %s: %w", remoteItemPath, err)
+			}
+		}
+	}
+
+	return nil
+}
+
+func (d *Device) PullFile(remotePath string, localPath string) (err error) {
+	// Create local file
+	localFile, err := os.Create(localPath)
+	if err != nil {
+		return fmt.Errorf("failed to create local file: %w", err)
+	}
+	defer localFile.Close()
+
+	// Use existing Pull method to pull file content
+	if err = d.Pull(remotePath, localFile); err != nil {
+		return fmt.Errorf("failed to pull file content: %w", err)
+	}
+
+	return nil
+}
+
 func (d *Device) installViaABBExec(apk io.ReadSeeker, args ...string) (raw []byte, err error) {
 	var (
 		tp       transport
diff --git a/pkg/gadb/device_test.go b/pkg/gadb/device_test.go
index 0a55e56b..8d8077a2 100644
--- a/pkg/gadb/device_test.go
+++ b/pkg/gadb/device_test.go
@@ -296,6 +296,17 @@ func TestDevice_Pull(t *testing.T) {
 	}
 }
 
+func TestDevice_PullFolder(t *testing.T) {
+	setupDevices(t)
+
+	for _, dev := range devices {
+		err := dev.PullFolder("/storage/emulated/0/Download/", "/tmp/test/")
+		if err != nil {
+			t.Fatal(err)
+		}
+	}
+}
+
 func TestDevice_ScreenRecord(t *testing.T) {
 	setupDevices(t)