GithubBackup/httprunner
1
0
Fork 0
mirror of https://github.com/httprunner/httprunner.git synced 2026-08-28 03:30:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(mcphost): optimize shutdown logging to avoid false error messages

Browse Source 
- Add identification for normal shutdown pipe errors in startStdioLog
- Optimize stdio log error handling logic to distinguish between normal shutdown and actual errors
- Add proper handling for SIGTERM (exit status 143) in isSignalError function
- Add debug logging for MCP config loading process
- Ensure clean shutdown without confusing error messages
This commit is contained in:
lilong.129
2025-06-03 13:21:38 +08:00
parent 184081592c
commit 37028c4263
3 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mcphost/host.go
+17 -1
View File
@@ -228,6 +228,7 @@ func isSignalError(err error) bool {
strings.Contains(errStr, "signal: terminated") ||
strings.Contains(errStr, "exit status 120") ||
strings.Contains(errStr, "exit status 130") ||
strings.Contains(errStr, "exit status 143") || // SIGTERM (15)
strings.Contains(errStr, "broken pipe") ||
strings.Contains(errStr, "connection reset")
}
@@ -472,7 +473,12 @@ func startStdioLog(stderr io.Reader, serverName string, ctx context.Context) {
} else {
// Scanner finished or encountered error
if err := scanner.Err(); err != nil {
log.Debug().Str("server", serverName).Err(err).Msg("stdio log scanner error")
// Check if it's a normal shutdown error (pipe closed)
if isNormalShutdownError(err) {
log.Debug().Str("server", serverName).Msg("stdio log stopped due to normal shutdown")
} else {
log.Debug().Str("server", serverName).Err(err).Msg("stdio log scanner error")
}
}
return
}
@@ -481,6 +487,16 @@ func startStdioLog(stderr io.Reader, serverName string, ctx context.Context) {
}()
}
// isNormalShutdownError checks if the error is caused by normal shutdown (pipe closed)
func isNormalShutdownError(err error) bool {
errStr := err.Error()
// Common pipe closed error patterns during normal shutdown
return strings.Contains(errStr, "file already closed") ||
strings.Contains(errStr, "broken pipe") ||
strings.Contains(errStr, "use of closed file") ||
strings.Contains(errStr, "read/write on closed pipe")
}
// prepareClientInitRequest creates a standard initialization request
func prepareClientInitRequest() mcp.InitializeRequest {
return mcp.InitializeRequest{