From 4f855de41936ee0985c68e4ebb31cc8b1388ffbe Mon Sep 17 00:00:00 2001 From: buyuxiang <347586493@qq.com> Date: Mon, 30 May 2022 20:56:11 +0800 Subject: [PATCH] bugfix: deal with empty base_url --- hrp/internal/convert/converter_har_test.go | 4 ++-- hrp/step_request.go | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hrp/internal/convert/converter_har_test.go b/hrp/internal/convert/converter_har_test.go index 0d4daa11..af94c98c 100644 --- a/hrp/internal/convert/converter_har_test.go +++ b/hrp/internal/convert/converter_har_test.go @@ -118,7 +118,7 @@ func TestMakeTestCaseFromHAR(t *testing.T) { if !assert.Equal(t, map[string]interface{}{"foo1": "HDnY8", "foo2": 12.3}, tCase.TestSteps[1].Request.Body) { t.Fatal() } - if !assert.Equal(t, "foo1=HDnY8&foo2=12.3", tCase.TestSteps[2].Request.Body) { + if !assert.Equal(t, map[string]string{"foo1": "HDnY8", "foo2": "12.3"}, tCase.TestSteps[2].Request.Body) { t.Fatal() } @@ -264,7 +264,7 @@ func TestMakeRequestDataParams(t *testing.T) { t.Fatal() } - if !assert.Equal(t, "a=1&b=2", step.Request.Body) { + if !assert.Equal(t, map[string]string{"a": "1", "b": "2"}, step.Request.Body) { t.Fatal() } } diff --git a/hrp/step_request.go b/hrp/step_request.go index 39e15d74..28b174ce 100644 --- a/hrp/step_request.go +++ b/hrp/step_request.go @@ -145,7 +145,10 @@ func (r *requestBuilder) prepareUrlParams(stepVariables map[string]interface{}) log.Error().Err(err).Msg("parse request url failed") return err } - baseURL := stepVariables["base_url"].(string) + var baseURL string + if stepVariables["base_url"] != nil { + baseURL = stepVariables["base_url"].(string) + } rawUrl := buildURL(baseURL, convertString(requestUrl)) // prepare request params