From 67690a06a4b8d96aff87a8f612edceb5e50089bc Mon Sep 17 00:00:00 2001 From: debugtalk Date: Fri, 26 Nov 2021 16:42:28 +0800 Subject: [PATCH] fix: EventTracking ev field type --- internal/ga/client_test.go | 4 +++- internal/ga/events.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/ga/client_test.go b/internal/ga/client_test.go index 6340a3d3..e0479611 100644 --- a/internal/ga/client_test.go +++ b/internal/ga/client_test.go @@ -8,6 +8,7 @@ func TestSendEvents(t *testing.T) { event := EventTracking{ Category: "unittest", Action: "SendEvents", + Value: "123", } err := gaClient.SendEvent(event) if err != nil { @@ -20,9 +21,10 @@ func TestStructToUrlValues(t *testing.T) { Category: "unittest", Action: "convert", Label: "StructToUrlValues", + Value: "123", } val := structToUrlValues(event) - if val.Encode() != "ea=convert&ec=unittest&el=StructToUrlValues" { + if val.Encode() != "ea=convert&ec=unittest&el=StructToUrlValues&ev=123" { t.Fail() } } diff --git a/internal/ga/events.go b/internal/ga/events.go index 2d0a10f7..71f62b1c 100644 --- a/internal/ga/events.go +++ b/internal/ga/events.go @@ -15,7 +15,7 @@ type EventTracking struct { Category string `form:"ec"` // Required. Event Category. Action string `form:"ea"` // Required. Event Action. Label string `form:"el"` // Optional. Event label - Value int `form:"ev"` // Optional. Event value + Value string `form:"ev"` // Optional. Event value, must be digits, "123" } func (e EventTracking) StartTiming(variable string) UserTimingTracking {