fix: display request & response details in report when extraction failed

docs/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+## 2.4.8 (2019-12-25)
+
+**Fixed**
+
+- fix: display request & response details in report when extraction failed
+
 ## 2.4.7 (2019-12-24)
 
 **Added**

httprunner/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "2.4.7"
+__version__ = "2.4.8"
 __description__ = "One-stop solution for HTTP(S) testing."
 
 __all__ = ["__version__", "__description__"]

httprunner/runner.py

@@ -245,32 +245,7 @@ class Runner(object):
         )
         resp_obj = response.ResponseObject(resp)
 
-        # teardown hooks
+        def log_req_resp_details():
-        teardown_hooks = test_dict.get("teardown_hooks", [])
-        if teardown_hooks:
-            self.session_context.update_test_variables("response", resp_obj)
-            self.do_hook_actions(teardown_hooks, "teardown")
-            self.http_client_session.update_last_req_resp_record(resp_obj)
-
-        # extract
-        extractors = test_dict.get("extract", {})
-        extracted_variables_mapping = resp_obj.extract_response(extractors)
-        self.session_context.update_session_variables(extracted_variables_mapping)
-
-        # validate
-        validators = test_dict.get("validate") or test_dict.get("validators") or []
-        validate_script = test_dict.get("validate_script", [])
-        if validate_script:
-            validators.append({
-                "type": "python_script",
-                "script": validate_script
-            })
-
-        validator = Validator(self.session_context, resp_obj)
-        try:
-            validator.validate(validators)
-        except (exceptions.ParamsError,
-                exceptions.ValidationFailure, exceptions.ExtractFailure):
             err_msg = "{} DETAILED REQUEST & RESPONSE {}\n".format("*" * 32, "*" * 32)
 
             # log request
@@ -291,12 +266,39 @@ class Runner(object):
             err_msg += "body: {}\n".format(repr(resp_obj.text))
             logger.log_error(err_msg)
 
+        # teardown hooks
+        teardown_hooks = test_dict.get("teardown_hooks", [])
+        if teardown_hooks:
+            self.session_context.update_test_variables("response", resp_obj)
+            self.do_hook_actions(teardown_hooks, "teardown")
+            self.http_client_session.update_last_req_resp_record(resp_obj)
+
+        # extract
+        extractors = test_dict.get("extract", {})
+        try:
+            extracted_variables_mapping = resp_obj.extract_response(extractors)
+            self.session_context.update_session_variables(extracted_variables_mapping)
+        except (exceptions.ParamsError, exceptions.ExtractFailure):
+            log_req_resp_details()
             raise
 
-        finally:
+        # validate
-            # get request/response data and validate results
+        validators = test_dict.get("validate") or test_dict.get("validators") or []
-            self.meta_datas = getattr(self.http_client_session, "meta_data", {})
+        validate_script = test_dict.get("validate_script", [])
-            self.meta_datas["validators"] = validator.validation_results
+        if validate_script:
+            validators.append({
+                "type": "python_script",
+                "script": validate_script
+            })
+
+        validator = Validator(self.session_context, resp_obj)
+        try:
+            validator.validate(validators)
+        except exceptions.ValidationFailure:
+            log_req_resp_details()
+            raise
+
+        return validator.validation_results
 
     def _run_testcase(self, testcase_dict):
         """ run single testcase.
@@ -374,13 +376,18 @@ class Runner(object):
             self._run_testcase(test_dict)
         else:
             # api
+            validation_results = {}
             try:
-                self._run_test(test_dict)
+                validation_results = self._run_test(test_dict)
             except Exception:
                 # log exception request_type and name for locust stat
                 self.exception_request_type = test_dict["request"]["method"]
                 self.exception_name = test_dict.get("name")
                 raise
+            finally:
+                # get request/response data and validate results
+                self.meta_datas = getattr(self.http_client_session, "meta_data", {})
+                self.meta_datas["validators"] = validation_results
 
     def export_variables(self, output_variables_list):
         """ export current testcase variables

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "httprunner"
-version = "2.4.7"
+version = "2.4.8"
 description = "One-stop solution for HTTP(S) testing."
 license = "Apache-2.0"
 readme = "README.md"