From d6b1cc5e1d553d1932f9da4829c26835b67c4ada Mon Sep 17 00:00:00 2001 From: xucong053 Date: Mon, 11 Apr 2022 14:55:57 +0800 Subject: [PATCH] fix: failed to generate html report while running demo_ref_testcase.yml #1237 --- hrp/session.go | 15 --------------- hrp/step_request.go | 11 +++++++++++ 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hrp/session.go b/hrp/session.go index 51966bb0..05173830 100644 --- a/hrp/session.go +++ b/hrp/session.go @@ -86,8 +86,6 @@ func (r *SessionRunner) Start() error { for k, v := range stepResult.ExportVars { r.sessionVariables[k] = v } - // update testcase summary - r.updateSummary(stepResult) log.Info(). Str("step", stepResult.Name). @@ -101,19 +99,6 @@ func (r *SessionRunner) Start() error { return nil } -// updateSummary appends step result to summary -func (r *SessionRunner) updateSummary(stepResult *StepResult) { - r.summary.Records = append(r.summary.Records, stepResult) - r.summary.Stat.Total += 1 - if stepResult.Success { - r.summary.Stat.Successes += 1 - } else { - r.summary.Stat.Failures += 1 - // update summary result to failed - r.summary.Success = false - } -} - // MergeStepVariables merges step variables with config variables and session variables func (r *SessionRunner) MergeStepVariables(vars map[string]interface{}) (map[string]interface{}, error) { // override variables diff --git a/hrp/step_request.go b/hrp/step_request.go index 6931ffd9..72074da7 100644 --- a/hrp/step_request.go +++ b/hrp/step_request.go @@ -378,6 +378,17 @@ func runStepRequest(r *SessionRunner, step *TStep) (stepResult *StepResult, err stepResult.ContentSize = resp.ContentLength stepResult.Data = sessionData + // update summary + r.summary.Records = append(r.summary.Records, stepResult) + r.summary.Stat.Total += 1 + if stepResult.Success { + r.summary.Stat.Successes += 1 + } else { + r.summary.Stat.Failures += 1 + // update summary result to failed + r.summary.Success = false + } + return stepResult, err }