From b3762dbbbc2197c641d5f9a251fe9f1a1a67ae97 Mon Sep 17 00:00:00 2001 From: debugtalk Date: Mon, 21 Feb 2022 18:25:01 +0800 Subject: [PATCH] fix: replace with github.com/andybalholm/brotli to avoid using cgo --- go.mod | 2 +- go.sum | 4 ++-- runner.go | 25 +++++++++++++++++++++++-- 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/go.mod b/go.mod index ac528d7f..3bbe6445 100644 --- a/go.mod +++ b/go.mod @@ -3,8 +3,8 @@ module github.com/httprunner/hrp go 1.16 require ( + github.com/andybalholm/brotli v1.0.4 github.com/denisbrodbeck/machineid v1.0.1 - github.com/google/brotli/go/cbrotli v0.0.0-20220110100810-f4153a09f87c github.com/google/uuid v1.3.0 github.com/httprunner/hrp/plugin v0.0.0 github.com/jinzhu/copier v0.3.2 diff --git a/go.sum b/go.sum index a4ce6c76..7332da7e 100644 --- a/go.sum +++ b/go.sum @@ -44,6 +44,8 @@ github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuy github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0= github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0= github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho= +github.com/andybalholm/brotli v1.0.4 h1:V7DdXeJtZscaqfNuAdSRuRFzuiKlHSC/Zh3zl9qY3JY= +github.com/andybalholm/brotli v1.0.4/go.mod h1:fO7iG3H7G2nSZ7m0zPUDn85XEX2GTukHGRSepvi9Eig= github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY= github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o= github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da/go.mod h1:Q73ZrmVTwzkszR9V5SSuryQ31EELlFMUz1kKyl939pY= @@ -127,8 +129,6 @@ github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaS github.com/golang/protobuf v1.5.1/go.mod h1:DopwsBzvsk0Fs44TXzsVbJyPhcCPeIwnvohx4u74HPM= github.com/golang/protobuf v1.5.2 h1:ROPKBNFfQgOUMifHyP+KYbvpjbdoFNs+aK7DXlji0Tw= github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= -github.com/google/brotli/go/cbrotli v0.0.0-20220110100810-f4153a09f87c h1:r47YgJ24CPvKxwxxHYPuE+FX1GgNtV93E7uaknKW0HU= -github.com/google/brotli/go/cbrotli v0.0.0-20220110100810-f4153a09f87c/go.mod h1:nOPhAkwVliJdNTkj3gXpljmWhjc4wCaVqbMJcPKWP4s= github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ= github.com/google/btree v1.0.0/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ= github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M= diff --git a/runner.go b/runner.go index cd29bf7b..6c6351b3 100644 --- a/runner.go +++ b/runner.go @@ -10,6 +10,7 @@ import ( "encoding/json" "fmt" "html/template" + "io" "io/ioutil" "net/http" "net/http/httputil" @@ -25,7 +26,7 @@ import ( "testing" "time" - "github.com/google/brotli/go/cbrotli" + "github.com/andybalholm/brotli" "github.com/jinzhu/copier" "github.com/pkg/errors" "github.com/rs/zerolog/log" @@ -807,10 +808,30 @@ func (r *caseRunner) runStepRequest(step *TStep) (stepResult *stepData, err erro return stepResult, err } +// convert brotli.Reader to io.ReadCloser, +// so that we can assign it to resp.Body +type brotliReader struct { + r io.Reader +} + +func (br *brotliReader) Read(p []byte) (n int, err error) { + return br.r.Read(p) +} + +func (br *brotliReader) Close() (err error) { + return nil +} + +func newBrotliReader(r io.Reader) io.ReadCloser { + b := &brotliReader{} + b.r = brotli.NewReader(r) + return b +} + func decodeResponseBody(resp *http.Response) error { switch resp.Header.Get("Content-Encoding") { case "br": - resp.Body = cbrotli.NewReader(resp.Body) + resp.Body = newBrotliReader(resp.Body) case "gzip": gr, err := gzip.NewReader(resp.Body) if err != nil {