From c21de865f391da0cefc036f479f2a23a218fe10a Mon Sep 17 00:00:00 2001
From: debugtalk <mail@debugtalk.com>
Date: Thu, 23 Apr 2020 18:46:18 +0800
Subject: [PATCH] change: remove `--failfast` argument, stop test run on the
 first error or failure by default

---
 docs/CHANGELOG.md         | 1 +
 httprunner/cli.py         | 4 ----
 httprunner/v3/api.py      | 5 ++---
 httprunner/v3/api_test.py | 4 ++--
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index b9441001..074c97b7 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -15,6 +15,7 @@
 - make `har2case` as hrun sub-command, usage: `hrun har2case -h`
 - make `locusts` as hrun sub-command, usage: `hrun locusts -h`
 - remove default header `HRUN-Request-ID`, implement the same function with global hooks
+- remove `--failfast` argument, stop test run on the first error or failure by default
 
 ## 3.0.1 (2020-03-24)
 
diff --git a/httprunner/cli.py b/httprunner/cli.py
index d215bc87..d8f04a4e 100644
--- a/httprunner/cli.py
+++ b/httprunner/cli.py
@@ -54,16 +54,12 @@ def init_parser_run(subparsers):
     sub_parser_run.add_argument(
         '--save-tests', action='store_true', default=False,
         help="Save loaded/parsed/vars_out/summary json data to JSON files.")
-    sub_parser_run.add_argument(
-        '--failfast', action='store_true', default=False,
-        help="Stop the test run on the first error or failure.")
 
     return sub_parser_run
 
 
 def main_run(args):
     runner = HttpRunner(
-        failfast=args.failfast,
         save_tests=args.save_tests,
         log_level=args.log_level,
         log_file=args.log_file
diff --git a/httprunner/v3/api.py b/httprunner/v3/api.py
index e4512c17..b844f9a0 100644
--- a/httprunner/v3/api.py
+++ b/httprunner/v3/api.py
@@ -26,11 +26,10 @@ class HttpRunner(object):
 
     """
 
-    def __init__(self, failfast=False, save_tests=False, log_level="WARNING", log_file=None):
+    def __init__(self, save_tests=False, log_level="WARNING", log_file=None):
         """ initialize HttpRunner.
 
         Args:
-            failfast (bool): stop the test run on the first error or failure.
             save_tests (bool): save loaded/parsed tests to JSON file.
             log_level (str): logging level.
             log_file (str): log file path.
@@ -38,7 +37,7 @@ class HttpRunner(object):
         """
         self.exception_stage = "initialize HttpRunner()"
         kwargs = {
-            "failfast": failfast,
+            "failfast": True,
             "resultclass": report.HtmlTestResult
         }
 
diff --git a/httprunner/v3/api_test.py b/httprunner/v3/api_test.py
index 94fa2f31..7db740b2 100644
--- a/httprunner/v3/api_test.py
+++ b/httprunner/v3/api_test.py
@@ -6,10 +6,10 @@ from httprunner.v3.api import HttpRunner
 class TestHttpRunner(unittest.TestCase):
 
     def setUp(self):
-        self.runner = HttpRunner(failfast=True)
+        self.runner = HttpRunner()
 
     def test_run_testcase_by_path(self):
         summary = self.runner.run_path("examples/postman_echo/request_methods/")
         self.assertTrue(summary.success)
-        self.assertEqual(summary.details[0].name, "request methods testcase with variables")
+        self.assertEqual(summary.testcases[0].name, "request methods testcase with variables")
         self.assertGreater(summary.stat.total, 1)