From 4697a538208f8d2135d981a6e455853eab32fa0f Mon Sep 17 00:00:00 2001 From: debugtalk Date: Thu, 3 Aug 2017 23:56:05 +0800 Subject: [PATCH 1/2] make comparator classified --- ate/utils.py | 47 ++++++++++++++++++++++++++++----------------- tests/test_utils.py | 26 +++++++++++-------------- 2 files changed, 40 insertions(+), 33 deletions(-) diff --git a/ate/utils.py b/ate/utils.py index 320412f6..9d6d6151 100644 --- a/ate/utils.py +++ b/ate/utils.py @@ -159,22 +159,6 @@ def match_expected(value, expected, comparator="eq", check_item=""): if comparator in ["eq", "equals", "=="]: assert value == expected - elif comparator in ["str_eq", "string_equals"]: - assert str(value) == str(expected) - elif comparator in ["ne", "not_equals"]: - assert value != expected - elif comparator in ["len_eq", "length_equal", "count_eq"]: - assert len(value) == expected - elif comparator in ["len_gt", "count_gt", "length_greater_than", "count_greater_than"]: - assert len(value) > expected - elif comparator in ["len_ge", "count_ge", "length_greater_than_or_equals", \ - "count_greater_than_or_equals"]: - assert len(value) >= expected - elif comparator in ["len_lt", "count_lt", "length_less_than", "count_less_than"]: - assert len(value) < expected - elif comparator in ["len_le", "count_le", "length_less_than_or_equals", \ - "count_less_than_or_equals"]: - assert len(value) <= expected elif comparator in ["lt", "less_than"]: assert value < expected elif comparator in ["le", "less_than_or_equals"]: @@ -183,16 +167,43 @@ def match_expected(value, expected, comparator="eq", check_item=""): assert value > expected elif comparator in ["ge", "greater_than_or_equals"]: assert value >= expected + elif comparator in ["ne", "not_equals"]: + assert value != expected + elif comparator in ["str_eq", "string_equals"]: + assert str(value) == str(expected) + elif comparator in ["len_eq", "length_equals", "count_eq"]: + assert isinstance(expected, int) + assert len(value) == expected + elif comparator in ["len_gt", "count_gt", "length_greater_than", "count_greater_than"]: + assert isinstance(expected, int) + assert len(value) > expected + elif comparator in ["len_ge", "count_ge", "length_greater_than_or_equals", \ + "count_greater_than_or_equals"]: + assert isinstance(expected, int) + assert len(value) >= expected + elif comparator in ["len_lt", "count_lt", "length_less_than", "count_less_than"]: + assert isinstance(expected, int) + assert len(value) < expected + elif comparator in ["len_le", "count_le", "length_less_than_or_equals", \ + "count_less_than_or_equals"]: + assert isinstance(expected, int) + assert len(value) <= expected elif comparator in ["contains"]: + assert isinstance(value, (list,tuple,dict,string_type)) assert expected in value elif comparator in ["contained_by"]: + assert isinstance(expected, (list,tuple,dict,string_type)) assert value in expected + elif comparator in ["type"]: + assert isinstance(value, expected) elif comparator in ["regex"]: + assert isinstance(expected, string_type) + assert isinstance(value, string_type) assert re.match(expected, value) - elif comparator in ["str_len", "string_length"]: - assert len(value) == int(expected) elif comparator in ["startswith"]: assert str(value).startswith(str(expected)) + elif comparator in ["endswith"]: + assert str(expected).startswith(str(value)) else: raise exception.ParamsError("comparator not supported!") diff --git a/tests/test_utils.py b/tests/test_utils.py index 9af1a1cb..5d7f9b75 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -156,42 +156,38 @@ class TestUtils(ApiServerUnittest): def test_match_expected(self): self.assertTrue(utils.match_expected(1, 1, "eq")) - self.assertTrue(utils.match_expected("abc", "abc", "eq")) + self.assertTrue(utils.match_expected("abc", "abc", "==")) self.assertTrue(utils.match_expected("abc", "abc")) with self.assertRaises(exception.ValidationError): utils.match_expected(123, "123", "eq") - with self.assertRaises(exception.ValidationError): utils.match_expected(123, "123") - self.assertTrue(utils.match_expected("123", 3, "len_eq")) - self.assertTrue(utils.match_expected(123, "123", "str_eq")) - self.assertTrue(utils.match_expected(123, "123", "ne")) - - self.assertTrue(utils.match_expected("123", 2, "len_gt")) - self.assertTrue(utils.match_expected("123", 3, "len_ge")) - self.assertTrue(utils.match_expected("123", 4, "len_lt")) - self.assertTrue(utils.match_expected("123", 3, "len_le")) - self.assertTrue(utils.match_expected(1, 2, "lt")) self.assertTrue(utils.match_expected(1, 1, "le")) self.assertTrue(utils.match_expected(2, 1, "gt")) self.assertTrue(utils.match_expected(1, 1, "ge")) + self.assertTrue(utils.match_expected(123, "123", "ne")) + + self.assertTrue(utils.match_expected("123", 3, "len_eq")) + self.assertTrue(utils.match_expected("123", 2, "len_gt")) + self.assertTrue(utils.match_expected("123", 3, "len_ge")) + self.assertTrue(utils.match_expected("123", 4, "len_lt")) + self.assertTrue(utils.match_expected("123", 3, "len_le")) self.assertTrue(utils.match_expected("123abc456", "3ab", "contains")) + self.assertTrue(utils.match_expected(['1', '2'], "1", "contains")) + self.assertTrue(utils.match_expected({'a':1, 'b':2}, "a", "contains")) self.assertTrue(utils.match_expected("3ab", "123abc456", "contained_by")) - self.assertTrue(utils.match_expected("123abc456", "^123.*456$", "regex")) + self.assertTrue(utils.match_expected("123abc456", "^123\w+456$", "regex")) with self.assertRaises(exception.ValidationError): utils.match_expected("123abc456", "^12b.*456$", "regex") with self.assertRaises(exception.ParamsError): utils.match_expected(1, 2, "not_supported_comparator") - self.assertTrue(utils.match_expected("2017-06-29 17:29:58", 19, "str_len")) - self.assertTrue(utils.match_expected("2017-06-29 17:29:58", "19", "str_len")) - self.assertTrue(utils.match_expected("abc123", "ab", "startswith")) self.assertTrue(utils.match_expected("123abc", 12, "startswith")) self.assertTrue(utils.match_expected(12345, 123, "startswith")) From 840600eccb8c81f4894d6f394d12893b9075315b Mon Sep 17 00:00:00 2001 From: debugtalk Date: Thu, 3 Aug 2017 23:58:06 +0800 Subject: [PATCH 2/2] add doc of comparator --- docs/comparator.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 docs/comparator.md diff --git a/docs/comparator.md b/docs/comparator.md new file mode 100644 index 00000000..74a7673f --- /dev/null +++ b/docs/comparator.md @@ -0,0 +1,22 @@ +# Comparator + +| comparator | Description | A(check), B(expected) | examples | +|:------------:|-----------|------------------------------------|-----------| +| `eq`, `==` | value is equal | A == B | 9 eq 9 | +| `lt` | less than | A < B | 7 lt 8 | +| `le` | less than or equals | A <= B | 7 le 8, 8 le 8 | +| `gt` | greater than | A > B | 8 gt 7 | +| `ge` | greater than or equals | A >= B | 8 ge 7, 8 ge 8 | +| `ne` | not equals | A != B | 6 ne 9 | +| `str_eq` | string equals | str(A) == str(B) | 123 str_eq '123' | +| `len_eq`, `count_eq` | length or count equals | len(A) == B | 'abc' len_eq 3
[1,2] len_eq 2 | +| `len_gt`, `count_gt` | length greater than | len(A) > B | 'abc' len_gt 2
[1,2,3] len_gt 2 | +| `len_ge`, `count_ge` | length greater than or equals | len(A) >= B | 'abc' len_ge 3
[1,2,3] len_gt 3 | +| `len_lt`, `count_lt` | length less than | len(A) < B | 'abc' len_lt 4
[1,2,3] len_lt 4 | +| `len_le`, `count_le` | length less than or equals | len(A) <= B | 'abc' len_le 3
[1,2,3] len_le 3 | +| `contains` | contains | B in A | [1, 2] contains 1
'abc' contains 'a' | +| `contained_by` | contained by | A in B | 1 contained_by [1,2]
'a' contained_by 'abc' | +| `type` | type of A is instance of B | isinstance(A, B) | 123 type 'int' | +| `regex` | regex matches | re.match(B, A) | 'abcdef' regex 'a\w+d' | +| `startswith` | starts with | A.startswith(B) is True | 'abc' startswith 'ab' | +| `endswith` | ends with | A.endswith(B) is True | 'abc' endswith 'bc' |