fix: potential file inclusion via variable

This commit is contained in:
lilong.129
2025-04-28 21:09:39 +08:00
parent 7132eec39e
commit da5042f0a4
6 changed files with 7 additions and 7 deletions

View File

@@ -119,7 +119,7 @@ func LoadCurlCase(path string) (*hrp.TestCaseDef, error) {
}
func readFileLines(path string) ([]string, error) {
file, err := os.OpenFile(path, os.O_RDONLY, 0o666)
file, err := os.OpenFile(path, os.O_RDONLY, 0o600)
if err != nil {
log.Error().Err(err).Str("path", path).Msg("open file failed")
return nil, err

View File

@@ -1 +1 @@
v5.0.0-beta-2504282106
v5.0.0-beta-2504282109

View File

@@ -536,7 +536,7 @@ func (d *Device) List(remotePath string) (devFileInfos []DeviceFileInfo, err err
}
func (d *Device) PushFile(localPath, remotePath string, modification ...time.Time) (err error) {
localFile, err := os.OpenFile(localPath, os.O_RDONLY, 0o666)
localFile, err := os.OpenFile(localPath, os.O_RDONLY, 0o600)
if err != nil {
return err
}
@@ -645,7 +645,7 @@ func (d *Device) installViaABBExec(apk io.ReadSeeker, args ...string) (raw []byt
}
func (d *Device) InstallAPK(apkPath string, args ...string) (string, error) {
apkFile, err := os.OpenFile(apkPath, os.O_RDONLY, 0o666)
apkFile, err := os.OpenFile(apkPath, os.O_RDONLY, 0o600)
if err != nil {
return "", errors.Wrap(err, fmt.Sprintf("open apk file %s failed", apkPath))
}

View File

@@ -95,7 +95,7 @@ func (s *Summary) GenHTMLReport() error {
}
reportPath := filepath.Join(reportsDir, "report.html")
file, err := os.OpenFile(reportPath, os.O_WRONLY|os.O_CREATE, 0o666)
file, err := os.OpenFile(reportPath, os.O_WRONLY|os.O_CREATE, 0o600)
if err != nil {
log.Error().Err(err).Msg("open file failed")
return err

View File

@@ -701,7 +701,7 @@ func (ad *ADBDriver) StopCaptureLog() (result interface{}, err error) {
return pointRes, nil
}
reader, err := os.OpenFile(files[0], os.O_RDONLY, 0o666)
reader, err := os.OpenFile(files[0], os.O_RDONLY, 0o600)
if err != nil {
log.Info().Msg("open File error")
return pointRes, nil

View File

@@ -970,7 +970,7 @@ func (wd *WDADriver) StartCaptureLog(identifier ...string) error {
func (wd *WDADriver) PushImage(localPath string) error {
log.Info().Str("localPath", localPath).Msg("WDADriver.PushImage")
localFile, err := os.OpenFile(localPath, os.O_RDONLY, 0o666)
localFile, err := os.OpenFile(localPath, os.O_RDONLY, 0o600)
if err != nil {
return err
}